Skip to content

vm: fix ASCII-betical order - #52686

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
avivkeller:patch-2
Apr 25, 2024
Merged

vm: fix ASCII-betical order#52686
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
avivkeller:patch-2

Conversation

@avivkeller

@avivkelleravivkeller commented Apr 25, 2024

Copy link
Copy Markdown
Member

This PR fixes an ASCII-betical issue.

Requesting fast-track as this prevents lint from passing on current builds.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Apr 25, 2024
@avivkelleravivkeller added fast-track PRs that do not need to wait for 48 hours to land. and removed vm Issues and PRs related to the vm subsystem. needs-ci PRs that need a full CI run. labels Apr 25, 2024
@github-actions

github-actionsBot commented Apr 25, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @redyetidev. Please 👍 to approve.

@avivkelleravivkeller added vm Issues and PRs related to the vm subsystem. needs-ci PRs that need a full CI run. labels Apr 25, 2024
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 25, 2024
@nodejs-github-bot

nodejs-github-bot commented Apr 25, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58694/

@nodejs-github-bot

nodejs-github-bot commented Apr 25, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58698/

@nodejs-github-bot

nodejs-github-bot commented Apr 25, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58705/

@avivkelleravivkeller added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 25, 2024
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 25, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 25, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 1728203 into nodejs:mainApr 25, 2024
@nodejs-github-bot

nodejs-github-bot commented Apr 25, 2024

Copy link
Copy Markdown
Collaborator

Landed in 1728203

@avivkeller
avivkeller deleted the patch-2 branch April 25, 2024 19:15
aduh95 pushed a commit that referenced this pull request Apr 29, 2024
@avivkeller@aduh95
vm: fix ASCII-betical order
d33131a
PR-URL: #52686
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@aduh95aduh95 mentioned this pull request Apr 30, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@richardlaurichardlaurichardlau approved these changes
@legendecaslegendecaslegendecas approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.vmIssues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@avivkeller@nodejs-github-bot@lpinca@richardlau@legendecas@aduh95@marco-ippolito