Skip to content

http: correctly translate HTTP method - #52701

Closed
ShogunPanda wants to merge 1 commit into
nodejs:mainfrom
ShogunPanda:http-search-all-methods
Closed

http: correctly translate HTTP method#52701
ShogunPanda wants to merge 1 commit into
nodejs:mainfrom
ShogunPanda:http-search-all-methods

Conversation

@ShogunPanda

@ShogunPandaShogunPanda commented Apr 26, 2024

Copy link
Copy Markdown
Contributor

This PR correctly maps the HTTP method reported by llhttp (which is an index of an array) to the right array.

Fixes#51562.

@nodejs-github-bot

nodejs-github-bot commented Apr 26, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http Issues or PRs related to the http subsystem. http_parser Issues and PRs related to the HTTP Parser dependency or the http_parser binding. needs-ci PRs that need a full CI run. labels Apr 26, 2024
@ShogunPandaShogunPanda mentioned this pull request Apr 26, 2024
Closed
mcollina
mcollina approved these changes Apr 26, 2024
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 26, 2024
@nodejs-github-bot

nodejs-github-bot commented Apr 26, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58729/

@nodejs-github-bot

nodejs-github-bot commented Apr 27, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58742/

@bricss

bricss commented Apr 27, 2024

Copy link
Copy Markdown
Contributor

I wonder if HTTP_KNOWN_METHODS(V) should be extended as well to make constants consistent?

@mcollina

mcollina commented Apr 27, 2024

Copy link
Copy Markdown
Member

@ShogunPanda C++ linting is failing

@ShogunPanda
ShogunPandaforce-pushed the http-search-all-methods branch from 99b3d19 to 71d3c02CompareMay 3, 2024 11:35
@ShogunPanda

ShogunPanda commented May 3, 2024

Copy link
Copy Markdown
ContributorAuthor

@mcollina Fixed.

@ShogunPandaShogunPanda added the request-ci Add this label to start a Jenkins CI on a PR. label May 3, 2024
@github-actionsgithub-actionsBot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels May 3, 2024
@github-actions

github-actionsBot commented May 3, 2024

Copy link
Copy Markdown
Contributor
Failed to start CI
 ⚠ Something was pushed to the Pull Request branch since the last approving review.
✘ Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/8938415767

@nodejs-github-bot

nodejs-github-bot commented May 3, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58892/

@nodejs-github-bot

nodejs-github-bot commented May 3, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58906/

jasnell pushed a commit that referenced this pull request May 4, 2024
@ShogunPanda@jasnell
http: correctly translate HTTP method
65c8380
PR-URL: #52701
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented May 4, 2024

Copy link
Copy Markdown
Member

Landed in 65c8380

@jasnelljasnell closed this May 4, 2024
@ShogunPanda
ShogunPanda deleted the http-search-all-methods branch May 5, 2024 05:32
targos pushed a commit that referenced this pull request May 8, 2024
@ShogunPanda@targos
http: correctly translate HTTP method
ad9c4bd
PR-URL: #52701
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request May 13, 2024
Merged
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@ShogunPanda@soophoo
http: correctly translate HTTP method
8726a30
PR-URL: nodejs#52701
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@kapouer

kapouer commented May 19, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

@jasnell Shouldn't this be backported to 20.x, since it now includes a more recent llhttp ?

marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
@ShogunPanda@marco-ippolito
http: correctly translate HTTP method
9623f48
PR-URL: #52701
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
@ShogunPanda@marco-ippolito
http: correctly translate HTTP method
8c77f73
PR-URL: #52701
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@marco-ippolitomarco-ippolito mentioned this pull request Jun 5, 2025
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 10, 2025
@ShogunPanda@marco-ippolito
http: correctly translate HTTP method
8670ed4
PR-URL: #52701
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 11, 2025
@ShogunPanda@marco-ippolito
http: correctly translate HTTP method
0556f54
PR-URL: #52701
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
n0v1
n0v1 reviewed Jun 26, 2025
View reviewed changes
Comment threadtest/parallel/test-http-server-method.query.js

@n0v1n0v1Jun 26, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Is the dot between method and query intended in the file name or should it be a hyphen instead?

@krzysdzkrzysdz mentioned this pull request Jun 30, 2026
Merged
@usualomausualoma mentioned this pull request Jul 15, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@panvapanvapanva approved these changes
@jasnelljasnelljasnell approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@ronagronagronag approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes
+1 more reviewer
@n0v1n0v1n0v1 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.http_parserIssues and PRs related to the HTTP Parser dependency or the http_parser binding.httpIssues or PRs related to the http subsystem.needs-ciPRs that need a full CI run.request-ci-failedAn error occurred while starting CI via request-ci label, and manual interventon is needed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support for 'QUERY' method

13 participants

@ShogunPanda@nodejs-github-bot@bricss@mcollina@jasnell@kapouer@panva@n0v1@benjamingr@ronag@marco-ippolito@targos@richardlau