Skip to content

deps: update undici to 6.15.0 - #52763

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
KhafraDev:update-undici
May 2, 2024
Merged

deps: update undici to 6.15.0#52763
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
KhafraDev:update-undici

Conversation

@KhafraDev

@KhafraDevKhafraDev commented Apr 30, 2024

Copy link
Copy Markdown
Member

Updates undici to v6.15.0 by running tools/dep_updaters/update-undici.sh and fixes test failures.

@nodejs-github-bot

nodejs-github-bot commented Apr 30, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Apr 30, 2024
@KhafraDevKhafraDev mentioned this pull request Apr 30, 2024
Closed
mcollina
mcollina approved these changes Apr 30, 2024
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina

mcollina commented Apr 30, 2024

Copy link
Copy Markdown
Member

linter is failing

@KhafraDev

KhafraDev commented Apr 30, 2024

Copy link
Copy Markdown
MemberAuthor

the tests should also pass once undici is updated again since the error messages were slightly improved

@mcollinamcollina added the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2024
@github-actionsgithub-actionsBot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels May 1, 2024
@github-actions

github-actionsBot commented May 1, 2024

Copy link
Copy Markdown
Contributor
Failed to start CI
 ⚠ Something was pushed to the Pull Request branch since the last approving review.
✘ Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/8907550593

@marco-ippolitomarco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2024
@nodejs-github-bot

nodejs-github-bot commented May 1, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58831/

mcollina
mcollina approved these changes May 1, 2024
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina mentioned this pull request May 1, 2024
Merged
@nodejs-github-bot

nodejs-github-bot commented May 1, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58834/

@nodejs-github-bot

nodejs-github-bot commented May 1, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58838/

@nodejs-github-bot

nodejs-github-bot commented May 2, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58851/

@mcollinamcollina added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels May 2, 2024
@panvapanva added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label May 2, 2024
@mcollina

mcollina commented May 2, 2024

Copy link
Copy Markdown
Member

This needs to wait 9 more hours to land

@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2024
@nodejs-github-bot
nodejs-github-bot merged commit ae8a5ff into nodejs:mainMay 2, 2024
@nodejs-github-bot

nodejs-github-bot commented May 2, 2024

Copy link
Copy Markdown
Collaborator

Landed in ae8a5ff

@KhafraDev
KhafraDev deleted the update-undici branch May 15, 2024 15:38
@KhafraDevKhafraDev mentioned this pull request May 15, 2024
Closed
targos pushed a commit that referenced this pull request Jun 1, 2024
@KhafraDev@targos
deps: update undici to 6.15.0
96f72ae
PR-URL: #52763
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jun 7, 2024
Merged
@marco-ippolitomarco-ippolito mentioned this pull request Jun 17, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@KhafraDev@marco-ippolito
deps: update undici to 6.15.0
f0a33f9
PR-URL: #52763
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@KhafraDev@eliphazbouye
deps: update undici to 6.15.0
5ef0213
PR-URL: nodejs#52763
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@KhafraDev@marco-ippolito
deps: update undici to 6.15.0
b32b62d
PR-URL: #52763
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@marco-ippolitomarco-ippolito mentioned this pull request Jul 19, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@panvapanvapanva approved these changes
@UlisesGasconUlisesGasconUlisesGascon approved these changes
@trivikrtrivikrtrivikr approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.dependenciesPull requests that update a dependency file.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@KhafraDev@nodejs-github-bot@mcollina@panva@UlisesGascon@trivikr@marco-ippolito