Skip to content

[v20.x backport] streams: implement TransformStream cleanup using "transformer.cancel" - #52772

Closed
MattiasBuelens wants to merge 1 commit into
nodejs:v20.x-stagingfrom
MattiasBuelens:backport-50126-to-v20.x
Closed

[v20.x backport] streams: implement TransformStream cleanup using "transformer.cancel"#52772
MattiasBuelens wants to merge 1 commit into
nodejs:v20.x-stagingfrom
MattiasBuelens:backport-50126-to-v20.x

Conversation

@MattiasBuelens

@MattiasBuelensMattiasBuelens commented May 1, 2024

Copy link
Copy Markdown
Contributor

Manual backport of #50126 to v20.x.

Fixes#49971

@nodejs-github-bot

nodejs-github-bot commented May 1, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. v20.x web streams labels May 1, 2024
@debadree25@MattiasBuelens
stream: implement TransformStream cleanup using "transformer.cancel"
d36fbc3
Fixes: nodejs#49971
PR-URL: nodejs#50126
Backport-PR-URL: nodejs#52772
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MattiasBuelens
MattiasBuelensforce-pushed the backport-50126-to-v20.x branch 2 times, most recently from 207856f to d36fbc3CompareMay 1, 2024 10:32
@MattiasBuelensMattiasBuelens mentioned this pull request May 1, 2024
Closed
@marco-ippolitomarco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2024
@nodejs-github-bot

nodejs-github-bot commented May 1, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/58837/

mcollina
mcollina approved these changes May 1, 2024
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marco-ippolito

marco-ippolito commented May 16, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Landed in 3dd96f1fabf3

marco-ippolito pushed a commit that referenced this pull request May 16, 2024
@debadree25@marco-ippolito
stream: implement TransformStream cleanup using "transformer.cancel"
3dd96f1
Fixes: #49971
PR-URL: #50126
Backport-PR-URL: #52772
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MattiasBuelens
MattiasBuelens deleted the backport-50126-to-v20.x branch May 16, 2024 08:35
@aliialii mentioned this pull request Jun 22, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.web streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@MattiasBuelens@nodejs-github-bot@marco-ippolito@mcollina@benjamingr@debadree25