Skip to content

doc: add more definitions to GLOSSARY.md - #52798

Merged
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
avivkeller:patch-2
May 5, 2024
Merged

doc: add more definitions to GLOSSARY.md#52798
nodejs-github-bot merged 6 commits into
nodejs:mainfrom
avivkeller:patch-2

Conversation

@avivkeller

@avivkelleravivkeller commented May 2, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Continuation of #31879, as no action from the author was taken in several years.

This PR uses the terms/definitions from the original PR and adds more. Additionally, the requested changes from that PR were also taken into account.

Supersedes: #31879

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label May 2, 2024
@avivkelleravivkeller added the meta Issues and PRs related to the general management of the project. label May 2, 2024
@aduh95

aduh95 commented May 2, 2024

Copy link
Copy Markdown
Contributor

Can you add the original author as a co-author please?

@avivkeller

avivkeller commented May 2, 2024

Copy link
Copy Markdown
MemberAuthor

Sure thing, I must've forgotten when I typed up the commit.

@aduh95

aduh95 commented May 3, 2024

Copy link
Copy Markdown
Contributor

Could you move the renaming of the file to simplifies reviews and avoid resetting the git blame? The renaming could probably be fast-tracked as it would be fairly trivial to review.

aduh95
aduh95 reviewed May 3, 2024
View reviewed changes
Comment threadglossary.md Outdated
aduh95
aduh95 reviewed May 3, 2024
View reviewed changes
Comment threadglossary.md Outdated
aduh95
aduh95 reviewed May 3, 2024
View reviewed changes
Comment threadglossary.md Outdated
Comment threadglossary.md Outdated
Comment threadglossary.md Outdated
Comment threadglossary.md Outdated
Comment threadglossary.md Outdated
Comment threadglossary.md Outdated
Comment threadglossary.md Outdated
Comment threadglossary.md Outdated
Comment threadglossary.md Outdated
Comment threadglossary.md Outdated
VoltrexKeyva
VoltrexKeyva reviewed May 3, 2024
View reviewed changes
Comment threadGLOSSARY.md Outdated
@avivkeller@HarshithaKP
doc: add more definitions to GLOSSARY.md
f6a159f
Co-Authored-By: Harshitha KP <harshi46@in.ibm.com>
aduh95
aduh95 reviewed May 5, 2024
View reviewed changes
Comment threadglossary.md Outdated
Comment threadglossary.md Outdated
Comment threadglossary.md Outdated
Comment threadglossary.md
aduh95
aduh95 reviewed May 5, 2024
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, just a few nits left

Comment threadglossary.md Outdated
Comment threadglossary.md Outdated
Comment threadglossary.md Outdated
avivkellerand others added 3 commits May 5, 2024 16:04
@avivkeller@aduh95
Update glossary.md
b83ff61
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@avivkeller@aduh95
Update glossary.md
73da548
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@avivkeller@aduh95
Update glossary.md
f47439c
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 5, 2024
@avivkelleravivkeller mentioned this pull request May 5, 2024
Closed
4 tasks
@aduh95aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 5, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 5, 2024
@nodejs-github-bot
nodejs-github-bot merged commit f500107 into nodejs:mainMay 5, 2024
@nodejs-github-bot

nodejs-github-bot commented May 5, 2024

Copy link
Copy Markdown
Collaborator

Landed in f500107

@avivkeller
avivkeller deleted the patch-2 branch May 5, 2024 22:33
targos pushed a commit that referenced this pull request May 8, 2024
@avivkeller@HarshithaKP@targos
doc: add more definitions to GLOSSARY.md
f770a99
Co-Authored-By: Harshitha KP <harshi46@in.ibm.com>
PR-URL: #52798
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targostargos mentioned this pull request May 13, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@avivkeller@HarshithaKP@marco-ippolito
doc: add more definitions to GLOSSARY.md
97e0fef
Co-Authored-By: Harshitha KP <harshi46@in.ibm.com>
PR-URL: #52798
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@marco-ippolitomarco-ippolito mentioned this pull request Jun 17, 2024
Merged
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@avivkeller@HarshithaKP@soophoo
doc: add more definitions to GLOSSARY.md
a6039d4
Co-Authored-By: Harshitha KP <harshi46@in.ibm.com>
PR-URL: nodejs#52798
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@aduh95aduh95aduh95 approved these changes
@VoltrexKeyvaVoltrexKeyvaAwaiting requested review from VoltrexKeyva

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@avivkeller@aduh95@nodejs-github-bot@jasnell@VoltrexKeyva