dgram: do not call callback if socket is closed by theanarkh · Pull Request #52829 · nodejs/node

theanarkh · 2024-05-04T07:58:48Z

Do not call callback if socket is closed.

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

nodejs-github-bot · 2024-05-04T07:58:53Z

Review requested:

@nodejs/net

github-actions · 2024-05-04T10:32:12Z

Failed to start CI

 ⚠ No approving reviews found
✘ Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/8949880553

mcollina

lgtm so we can start CI

nodejs-github-bot · 2024-05-18T05:41:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59279/

nodejs-github-bot · 2024-05-18T07:21:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59282/

nodejs-github-bot · 2024-05-19T09:01:51Z

Commit Queue failed

- Loading data for nodejs/node/pull/52829
✔ Done loading data for nodejs/node/pull/52829
----------------------------------- PR info ------------------------------------
Title dgram: do not call callback if socket is closed (#52829)
Author theanarkh (@theanarkh)
Branch theanarkh:dont-emit-error-after-close-handle -> nodejs:main
Labels dgram, needs-ci
Commits 1
- lib: do not call callback if socket is closed
Committers 1
- theanarkh PR-URL: https://github.com/nodejs/node/pull/52829
Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/52829
Reviewed-By: Matteo Collina --------------------------------------------------------------------------------
⚠ Commits were pushed since the last approving review:
⚠ - lib: do not call callback if socket is closed
ℹ This PR was created on Sat, 04 May 2024 07:58:48 GMT
✔ Approvals: 1
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/52829#pullrequestreview-2057177270
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2024-05-18T07:21:46Z: https://ci.nodejs.org/job/node-test-pull-request/59282/
- Querying data for job/node-test-pull-request/59282/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/9146455101

nodejs-github-bot · 2024-05-19T10:46:53Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59301/

nodejs-github-bot · 2024-05-19T15:56:43Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59302/

nodejs-github-bot · 2024-05-20T02:35:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/59308/

mcollina

lgtm

nodejs-github-bot · 2024-05-23T20:32:26Z

Landed in f05baff

PR-URL: #52829 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

PR-URL: nodejs#52829 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

PR-URL: #52829 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

nodejs-github-bot added dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run. labels May 4, 2024

theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label May 4, 2024

github-actionsBot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels May 4, 2024

mcollina reviewed May 6, 2024
View reviewed changes

Comment threadtest/parallel/test-dgram-bind-socket-close-before-cluster-reply.js Outdated

ShogunPanda reviewed May 15, 2024
View reviewed changes

Comment threadlib/dgram.js Outdated

mcollina changed the title ~~lib: do not call callback if socket is closed~~dgram: do not call callback if socket is closedMay 15, 2024

mcollina approved these changes May 15, 2024
View reviewed changes

mcollina added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels May 15, 2024

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2024

lib: do not call callback if socket is closed
d022b6c

theanarkh force-pushed the dont-emit-error-after-close-handle branch from 9aeee94 to d022b6cCompare May 15, 2024 11:48

theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label May 18, 2024

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 18, 2024

mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label May 19, 2024

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 19, 2024

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label May 19, 2024

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 19, 2024

theanarkh added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 20, 2024

aduh95 requested a review from mcollina May 23, 2024 15:15

mcollina approved these changes May 23, 2024
View reviewed changes

mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2024

nodejs-github-bot merged commit f05baff into nodejs:mainMay 23, 2024

targos pushed a commit that referenced this pull request Jun 1, 2024
lib: do not call callback if socket is closed
040be4a
PR-URL: #52829 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

RafaelGSS mentioned this pull request Jun 7, 2024
v22.3.0 proposal #53379
Merged

soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
lib: do not call callback if socket is closed
91348b0
PR-URL: nodejs#52829 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
lib: do not call callback if socket is closed
23f086c
PR-URL: #52829 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

marco-ippolito mentioned this pull request Jul 19, 2024
v20.16.0 proposal #53945
Merged

Navigation Menu

Uh oh!

Uh oh!

dgram: do not call callback if socket is closed - #52829

dgram: do not call callback if socket is closed#52829
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:dont-emit-error-after-close-handle

theanarkh commented May 4, 2024

Uh oh!

nodejs-github-bot commented May 4, 2024

Uh oh!

github-actionsBot commented May 4, 2024

Uh oh!

Uh oh!

Uh oh!

mcollina left a comment

Uh oh!

nodejs-github-bot commented May 18, 2024

Uh oh!

nodejs-github-bot commented May 18, 2024

Uh oh!

nodejs-github-bot commented May 19, 2024

Uh oh!

nodejs-github-bot commented May 19, 2024

Uh oh!

nodejs-github-bot commented May 19, 2024

Uh oh!

nodejs-github-bot commented May 20, 2024

Uh oh!

mcollina left a comment

Uh oh!

nodejs-github-bot commented May 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

theanarkh commented May 4, 2024

Uh oh!

nodejs-github-bot commented May 4, 2024

Uh oh!

github-actionsBot commented May 4, 2024

Uh oh!

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented May 18, 2024

Uh oh!

nodejs-github-bot commented May 18, 2024

Uh oh!

nodejs-github-bot commented May 19, 2024

Uh oh!

nodejs-github-bot commented May 19, 2024

Uh oh!

nodejs-github-bot commented May 19, 2024

Uh oh!

nodejs-github-bot commented May 20, 2024

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented May 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants