tools: use sccache GitHub action by targos · Pull Request #52839 · nodejs/node

targos · 2024-05-05T11:45:39Z

Refs: https://github.com/Mozilla-Actions/sccache-action

nodejs-github-bot · 2024-05-05T11:45:44Z

Review requested:

@nodejs/actions

targos · 2024-05-05T11:50:14Z

I'll push the yaml lint fix after the test workflow is finished so we can see if it then uses the cache

targos · 2024-05-05T14:54:57Z

Build time without cache: 1h21m
Build time with cache: 16m

MoLow

This is incredible. can it be added to other workflows?

Co-authored-by: Moshe Atlow <moshe@atlow.co.il>

targos · 2024-05-05T15:24:35Z

Can it be added to other workflows?

Certainly, but I suggest we start only with one and monitor it for a few days before applying to others.

targos · 2024-05-05T17:15:09Z

I think the third run didn't use the previous cache because of c7e4209. I restarted it.

github-actions · 2024-05-05T21:27:09Z

Fast-track has been requested by @anonrig. Please 👍 to approve.

nodejs-github-bot · 2024-05-06T07:50:53Z

Commit Queue failed

- Loading data for nodejs/node/pull/52839 ✔ Done loading data for nodejs/node/pull/52839 ----------------------------------- PR info ------------------------------------ Title tools: use sccache GitHub action (#52839) Author Michaël Zasso (@targos) Branch targos:sccache -> nodejs:main Labels meta, fast-track, author ready Commits 3 - tools: use sccache GitHub action - lint - Update .github/workflows/test-linux.yml Committers 2 - Michaël Zasso - GitHub PR-URL: https://github.com/nodejs/node/pull/52839 Refs: https://github.com/Mozilla-Actions/sccache-action Reviewed-By: Moshe Atlow Reviewed-By: Yagiz Nizipli Reviewed-By: Benjamin Gruenbaum Reviewed-By: Marco Ippolito Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/52839 Refs: https://github.com/Mozilla-Actions/sccache-action Reviewed-By: Moshe Atlow Reviewed-By: Yagiz Nizipli Reviewed-By: Benjamin Gruenbaum Reviewed-By: Marco Ippolito Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 05 May 2024 11:45:39 GMT ✔ Approvals: 5 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/52839#pullrequestreview-2039719111 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/52839#pullrequestreview-2039729543 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/52839#pullrequestreview-2039764491 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/52839#pullrequestreview-2039767711 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/52839#pullrequestreview-2039778872 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 52839 From https://github.com/nodejs/node * branch refs/pull/52839/merge -> FETCH_HEAD ✔ Fetched commits as e5a76f16e11b..4961c7af469f -------------------------------------------------------------------------------- [main 6db8a08c4c] tools: use sccache GitHub action Author: Michaël Zasso Date: Sun May 5 13:45:10 2024 +0200 1 file changed, 8 insertions(+) [main 2426339528] lint Author: Michaël Zasso Date: Sun May 5 16:35:16 2024 +0200 1 file changed, 2 insertions(+), 2 deletions(-) [main 9cf34aa272] Update .github/workflows/test-linux.yml Author: Michaël Zasso Date: Sun May 5 17:12:07 2024 +0200 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. Rebasing (2/6)

Executing: git node land --amend --yes
⚠ Found Refs: https://github.com/Mozilla-Actions/sccache-action, skipping..
--------------------------------- New Message ----------------------------------
tools: use sccache GitHub action

Refs: https://github.com/Mozilla-Actions/sccache-action
PR-URL: #52839
Reviewed-By: Moshe Atlow moshe@atlow.co.il
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Marco Ippolito marcoippolito54@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD 8e3719a7f6] tools: use sccache GitHub action
Author: Michaël Zasso targos@protonmail.com
Date: Sun May 5 13:45:10 2024 +0200
1 file changed, 8 insertions(+)
Rebasing (3/6)
Rebasing (4/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
lint

PR-URL: #52839
Refs: https://github.com/Mozilla-Actions/sccache-action
Reviewed-By: Moshe Atlow moshe@atlow.co.il
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Marco Ippolito marcoippolito54@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD 180a5a3c93] lint
Author: Michaël Zasso targos@protonmail.com
Date: Sun May 5 16:35:16 2024 +0200
1 file changed, 2 insertions(+), 2 deletions(-)
Rebasing (5/6)
Rebasing (6/6)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update .github/workflows/test-linux.yml

Co-authored-by: Moshe Atlow moshe@atlow.co.il
PR-URL: #52839
Refs: https://github.com/Mozilla-Actions/sccache-action
Reviewed-By: Moshe Atlow moshe@atlow.co.il
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Marco Ippolito marcoippolito54@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com

[detached HEAD 5587cfb240] Update .github/workflows/test-linux.yml
Author: Michaël Zasso targos@protonmail.com
Date: Sun May 5 17:12:07 2024 +0200
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/8965783780

nodejs-github-bot · 2024-05-06T07:59:19Z

Landed in bbace72

Refs: https://github.com/Mozilla-Actions/sccache-action PR-URL: #52839 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

MoLow · 2024-05-30T07:41:42Z

@targos WDYT abod expanding this to other workflows now that is seems to work nicely?

targos · 2024-05-30T08:47:21Z

SGTM

Refs: https://github.com/Mozilla-Actions/sccache-action PR-URL: #52839 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Refs: https://github.com/Mozilla-Actions/sccache-action PR-URL: nodejs#52839 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

tools: use sccache GitHub action
28b76b5
Refs: https://github.com/Mozilla-Actions/sccache-action

targos added the wip Issues and PRs that are still a work in progress. label May 5, 2024

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 5, 2024

lint
a167274

targos removed the wip Issues and PRs that are still a work in progress. label May 5, 2024

MoLow approved these changes May 5, 2024
View reviewed changes

MoLow reviewed May 5, 2024
View reviewed changes

Comment thread.github/workflows/test-linux.yml Outdated

Update .github/workflows/test-linux.yml
4961c7a
Co-authored-by: Moshe Atlow <moshe@atlow.co.il>

MoLow approved these changes May 5, 2024
View reviewed changes

anonrig approved these changes May 5, 2024
View reviewed changes

targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 5, 2024

benjamingr approved these changes May 5, 2024
View reviewed changes

marco-ippolito approved these changes May 5, 2024
View reviewed changes

lpinca approved these changes May 5, 2024
View reviewed changes

anonrig added the fast-track PRs that do not need to wait for 48 hours to land. label May 5, 2024

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2024

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label May 6, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 6, 2024

nodejs-github-bot merged commit bbace72 into nodejs:mainMay 6, 2024

targos deleted the sccache branch May 6, 2024 08:27

targos mentioned this pull request May 13, 2024
v22.2.0 release proposal #52971
Merged

MoLow mentioned this pull request Jun 3, 2024
tools: use sccache Github action #53316
Merged

marco-ippolito mentioned this pull request Jun 17, 2024
v20.15.0 proposal #53486
Merged

Navigation Menu

Uh oh!

Uh oh!

tools: use sccache GitHub action - #52839

tools: use sccache GitHub action#52839
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
targos:sccache

targos commented May 5, 2024

Uh oh!

nodejs-github-bot commented May 5, 2024

Uh oh!

targos commented May 5, 2024

Uh oh!

targos commented May 5, 2024

Uh oh!

MoLow left a comment

Uh oh!

Uh oh!

targos commented May 5, 2024

Uh oh!

targos commented May 5, 2024

Uh oh!

github-actionsBot commented May 5, 2024

Uh oh!

nodejs-github-bot commented May 6, 2024

Successfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented May 6, 2024

Uh oh!

MoLow commented May 30, 2024

Uh oh!

targos commented May 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Uh oh!

Conversation

targos commented May 5, 2024

Uh oh!

nodejs-github-bot commented May 5, 2024

Uh oh!

targos commented May 5, 2024

Uh oh!

targos commented May 5, 2024

Uh oh!

MoLow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

targos commented May 5, 2024

Uh oh!

targos commented May 5, 2024

Uh oh!

github-actionsBot commented May 5, 2024

Uh oh!

nodejs-github-bot commented May 6, 2024

Successfully rebased and updated refs/heads/main.

Uh oh!

nodejs-github-bot commented May 6, 2024

Uh oh!

MoLow commented May 30, 2024

Uh oh!

targos commented May 30, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants