Uh oh!
There was an error while loading. Please reload this page.
doc: improve unhandledException doc copy - #5287
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Tiniest nit: consistent would be "Example:" afaik
eljefedelrodeodeljefe
commented
Feb 20, 2016
Contributor
Good one. LGTM, minus (nit and) conflicts. /cc @nodejs/documentation |
a0viedo
commented
Feb 24, 2016
Member
LGTM |
Contributor
There was a problem hiding this comment.
Isn't this line longer than the usual limit?
MemberAuthor
There was a problem hiding this comment.
yep, will correct the wrapping on landing.
jasnell
commented
Mar 2, 2016
MemberAuthor
@nodejs/documentation ... can I get some more LGTM's on this from Collaborators? |
r-52
commented
Mar 2, 2016
Contributor
LGTM |
thefourtheye
commented
Mar 3, 2016
Contributor
LGTM - the merge conflict. |
jasnell
commented
Mar 3, 2016
MemberAuthor
yep, will rebase before landing |
Rework the doc a bit to tighten it up, including removing the use of `you`
jasnellforce-pushed
the
doc-unhandled-exception-improvement
branch
from
March 3, 2016 20:57
1657b60 to
72d29e6Comparejasnell
commented
Mar 3, 2016
MemberAuthor
Rebased! |
jasnell added a commit
that referenced
this pull request
Mar 3, 2016
Rework the doc a bit to tighten it up, including removing the use of `you` Fix some line wrapping issues. PR-URL: #5287 Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> ...
jasnell
commented
Mar 3, 2016
MemberAuthor
Landed in 831b30e |
Merged
Fishrock123 pushed a commit
that referenced
this pull request
Mar 8, 2016
Rework the doc a bit to tighten it up, including removing the use of `you` Fix some line wrapping issues. PR-URL: #5287 Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> ...
Fishrock123 pushed a commit
that referenced
this pull request
Mar 8, 2016
Rework the doc a bit to tighten it up, including removing the use of `you` Fix some line wrapping issues. PR-URL: #5287 Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> ...
MylesBorins pushed a commit
that referenced
this pull request
Mar 17, 2016
Rework the doc a bit to tighten it up, including removing the use of `you` Fix some line wrapping issues. PR-URL: #5287 Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> ...
MylesBorins pushed a commit
that referenced
this pull request
Mar 21, 2016
Rework the doc a bit to tighten it up, including removing the use of `you` Fix some line wrapping issues. PR-URL: #5287 Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the doc a bit to tighten it up, including removing the
use of
you