Uh oh!
There was an error while loading. Please reload this page.
build: exit on unsupported host OS for Android - #52882
Merged
Merged
Conversation
lpinca
commented
May 11, 2024
Member
Wouldn't it be better to fix it here Lines 13 to 15 in cbd6ddb |
The Android configure script throws an unhelpful error message telling the user that `toolchain_path` is not defined when the script is run on an unsupported host OS, exit with a more helpful message instead while listing the supported host OSes.
lpinca
approved these changes
May 11, 2024
VoltrexKeyva
commented
May 22, 2024
ContributorAuthor
I assume this doesn't need a Jenkins CI right? |
jasnell
approved these changes
May 25, 2024
nodejs-github-bot
commented
May 25, 2024
Collaborator
Landed in 0cbbab9 |
targos pushed a commit
that referenced
this pull request
Jun 1, 2024
The Android configure script throws an unhelpful error message telling the user that `toolchain_path` is not defined when the script is run on an unsupported host OS, exit with a more helpful message instead while listing the supported host OSes. PR-URL: #52882 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
eliphazbouye pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
The Android configure script throws an unhelpful error message telling the user that `toolchain_path` is not defined when the script is run on an unsupported host OS, exit with a more helpful message instead while listing the supported host OSes. PR-URL: nodejs#52882 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito pushed a commit
that referenced
this pull request
Jul 19, 2024
The Android configure script throws an unhelpful error message telling the user that `toolchain_path` is not defined when the script is run on an unsupported host OS, exit with a more helpful message instead while listing the supported host OSes. PR-URL: #52882 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Balmasexy
commented
Mar 15, 2025
The Android configure script throws an unhelpful error message telling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Android configure script throws an unhelpful error message telling the user that
toolchain_pathis not defined when the script is run on an unsupported host OS, exit with a more helpful message instead while listing the supported host OSes.