Skip to content

deps: enable unbundling of simdjson, simdutf, ada - #52924

Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
lemire:make_simdutf_simdjson_ada_unbound
May 11, 2024
Merged

deps: enable unbundling of simdjson, simdutf, ada#52924
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
lemire:make_simdutf_simdjson_ada_unbound

Conversation

@lemire

@lemirelemire commented May 9, 2024

Copy link
Copy Markdown
Member

When building Node.js, it is possible to replace most dependencies by locally provided ones. However, it does not apply for at least three dependencies: simdjson, simdutf, ada. This PR seeks to enable this possibility.

Fixes#52914

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels May 9, 2024
@lemire
lemire requested review from anonrig and jasnellMay 9, 2024 19:08
@lemire

lemire commented May 9, 2024

Copy link
Copy Markdown
MemberAuthor

cc @williamh

@lemire
lemire requested review from benjamingr and kvakilMay 9, 2024 19:09
@anonrig

anonrig commented May 9, 2024

Copy link
Copy Markdown
Member

cc @nodejs/build @richardlau

richardlau
richardlau reviewed May 9, 2024
View reviewed changes

@richardlaurichardlau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the default libnames are the same as the * part of the --shared-*-libname pattern. Please amend accordingly if not. They're almost certainly not likely to be z 🙂.

Comment threadconfigure.py Outdated
Comment threadconfigure.py Outdated
Comment threadconfigure.py Outdated
@williamh

williamh commented May 9, 2024

Copy link
Copy Markdown

Is it possible to add ngtcp2 to this pr, or should that be done in another pr?
Thanks much

lemireand others added 3 commits May 9, 2024 16:21
@lemire@richardlau
Update configure.py
53ca846
Co-authored-by: Richard Lau <rlau@redhat.com>
@lemire@richardlau
Update configure.py
fbc612d
Co-authored-by: Richard Lau <rlau@redhat.com>
@lemire@richardlau
Update configure.py
2356b7d
Co-authored-by: Richard Lau <rlau@redhat.com>
@lemire

lemire commented May 9, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@williamh My reading of the code is that ngtcp2 can be made unbundled right now. But gentoo does not choose to do so. I think @jasnell did add this feature already.

@williamh

williamh commented May 9, 2024

Copy link
Copy Markdown

Ok, thanks for this info, I'll take a look at my side again.

@richardlaurichardlau added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels May 9, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 9, 2024
@nodejs-github-bot

nodejs-github-bot commented May 9, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59068/

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 11, 2024
@nodejs-github-bot
nodejs-github-bot merged commit d78537b into nodejs:mainMay 11, 2024
@nodejs-github-bot

nodejs-github-bot commented May 11, 2024

Copy link
Copy Markdown
Collaborator

Landed in d78537b

targos pushed a commit that referenced this pull request May 12, 2024
@lemire@targos
deps: enable unbundling of simdjson, simdutf, ada
232831f
PR-URL: #52924
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targostargos mentioned this pull request May 13, 2024
Merged
@marco-ippolitomarco-ippolito mentioned this pull request Jun 17, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@lemire@marco-ippolito
deps: enable unbundling of simdjson, simdutf, ada
b774544
PR-URL: #52924
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@lemire@soophoo
deps: enable unbundling of simdjson, simdutf, ada
12ed8ee
PR-URL: nodejs#52924
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@jirutkajirutka mentioned this pull request Nov 16, 2024
Closed
jirutka added a commit to jirutka/node that referenced this pull request Nov 16, 2024
@jirutka
build: compile bundled ada conditionally
78bd0ab
The --shared-ada flag was introduced in nodejs#52924, but the implementation
was incomplete.
Resolvesnodejs#52914
jirutka added a commit to jirutka/node that referenced this pull request Nov 16, 2024
@jirutka
build: compile bundled simdjson conditionally
077b553
The --shared-simdjson flag was introduced in nodejs#52924, but the
implementation was incomplete.
Resolvesnodejs#52914
jirutka added a commit to jirutka/node that referenced this pull request Nov 16, 2024
@jirutka
build: compile bundled simdutf conditionally
4a035b3
The --shared-simdutf flag was introduced in nodejs#52924, but the
implementation was incomplete.
Resolvesnodejs#52914
nodejs-github-bot pushed a commit that referenced this pull request Nov 18, 2024
@jirutka@nodejs-github-bot
build: compile bundled ada conditionally
88719f6
The --shared-ada flag was introduced in #52924, but the implementation
was incomplete.
Resolves#52914
PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit that referenced this pull request Nov 18, 2024
@jirutka@nodejs-github-bot
build: compile bundled simdjson conditionally
dd15563
The --shared-simdjson flag was introduced in #52924, but the
implementation was incomplete.
Resolves#52914
PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
nodejs-github-bot pushed a commit that referenced this pull request Nov 18, 2024
@jirutka@nodejs-github-bot
build: compile bundled simdutf conditionally
64c647e
The --shared-simdutf flag was introduced in #52924, but the
implementation was incomplete.
Resolves#52914
PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95 pushed a commit that referenced this pull request Nov 26, 2024
@jirutka@aduh95
build: compile bundled ada conditionally
83e02dc
The --shared-ada flag was introduced in #52924, but the implementation
was incomplete.
Resolves#52914
PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95 pushed a commit that referenced this pull request Nov 26, 2024
@jirutka@aduh95
build: compile bundled simdjson conditionally
d8eb83c
The --shared-simdjson flag was introduced in #52924, but the
implementation was incomplete.
Resolves#52914
PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95 pushed a commit that referenced this pull request Nov 26, 2024
@jirutka@aduh95
build: compile bundled simdutf conditionally
fffabca
The --shared-simdutf flag was introduced in #52924, but the
implementation was incomplete.
Resolves#52914
PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95 pushed a commit that referenced this pull request Dec 10, 2024
@jirutka@aduh95
build: compile bundled ada conditionally
50faa64
The --shared-ada flag was introduced in #52924, but the implementation
was incomplete.
Resolves#52914
PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95 pushed a commit that referenced this pull request Dec 10, 2024
@jirutka@aduh95
build: compile bundled simdjson conditionally
e309310
The --shared-simdjson flag was introduced in #52924, but the
implementation was incomplete.
Resolves#52914
PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
aduh95 pushed a commit that referenced this pull request Dec 10, 2024
@jirutka@aduh95
build: compile bundled simdutf conditionally
f557c0e
The --shared-simdutf flag was introduced in #52924, but the
implementation was incomplete.
Resolves#52914
PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
ruyadorno pushed a commit that referenced this pull request Jan 5, 2025
@jirutka@ruyadorno
build: compile bundled ada conditionally
1015b22
The --shared-ada flag was introduced in #52924, but the implementation
was incomplete.
Resolves#52914
PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
ruyadorno pushed a commit that referenced this pull request Jan 5, 2025
@jirutka@ruyadorno
build: compile bundled simdjson conditionally
826fd35
The --shared-simdjson flag was introduced in #52924, but the
implementation was incomplete.
Resolves#52914
PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
ruyadorno pushed a commit that referenced this pull request Jan 5, 2025
@jirutka@ruyadorno
build: compile bundled simdutf conditionally
8d70b99
The --shared-simdutf flag was introduced in #52924, but the
implementation was incomplete.
Resolves#52914
PR-URL: #55886
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes
@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes
@richardlaurichardlaurichardlau approved these changes
@jasnelljasnellAwaiting requested review from jasnell
@kvakilkvakilAwaiting requested review from kvakil

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

please allow the use of the simdjson library provided by the distribution

7 participants

@lemire@anonrig@williamh@nodejs-github-bot@benjamingr@lpinca@richardlau