Skip to content

test: mark test-benchmark-crypto as flaky - #52955

Closed
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:test-benchmark-crypto-flaky
Closed

test: mark test-benchmark-crypto as flaky#52955
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:test-benchmark-crypto-flaky

Conversation

@aduh95

@aduh95aduh95 commented May 12, 2024

Copy link
Copy Markdown
Contributor

Refs: #52690

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 12, 2024
@rithvikvibhurithvikvibhu mentioned this pull request Jun 2, 2024
Closed
@aduh95aduh95 added stalled Issues and PRs that are stalled. review wanted PRs that need reviews. labels Jun 27, 2024
@github-actions

github-actionsBot commented Jun 27, 2024

Copy link
Copy Markdown
Contributor

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

@richardlaurichardlau added request-ci Add this label to start a Jenkins CI on a PR. and removed stalled Issues and PRs that are stalled. labels Jun 27, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 27, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 28, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 28, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 28, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60005/

@richardlaurichardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 28, 2024
jasnell pushed a commit that referenced this pull request Jun 30, 2024
@aduh95@jasnell
test: mark test-benchmark-crypto as flaky
fe2d4dc
PR-URL: #52955
Refs: #52690
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Jun 30, 2024

Copy link
Copy Markdown
Member

Landed in fe2d4dc

@jasnelljasnell closed this Jun 30, 2024
targos pushed a commit that referenced this pull request Jul 1, 2024
@aduh95@targos
test: mark test-benchmark-crypto as flaky
6e66d97
PR-URL: #52955
Refs: #52690
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Jul 1, 2024
Merged
@Karliz24Karliz24 mentioned this pull request Jul 9, 2024
Open
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@aduh95@marco-ippolito
test: mark test-benchmark-crypto as flaky
24f078a
PR-URL: #52955
Refs: #52690
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@marco-ippolitomarco-ippolito mentioned this pull request Jul 19, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.review wantedPRs that need reviews.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95@nodejs-github-bot@jasnell@richardlau