Skip to content

doc: improve for httpVersionMajor & httpVersionMinor - #5296

Closed
JacksonTian wants to merge 1 commit into
nodejs:masterfrom
JacksonTian:http_version
Closed

doc: improve for httpVersionMajor & httpVersionMinor#5296
JacksonTian wants to merge 1 commit into
nodejs:masterfrom
JacksonTian:http_version

Conversation

@JacksonTian

Copy link
Copy Markdown
Contributor

The description of httpVersionMajor & httpVersionMinor should
have same context like httpVersion.

The description of httpVersionMarjor & httpVersionMinor should
have same context like httpVersion.
@mscdexmscdex added http Issues or PRs related to the http subsystem. doc Issues and PRs related to the documentations. labels Feb 18, 2016
@silverwindsilverwind changed the title doc: improve for httpVersionMarjor & httpVersionMinordoc: improve for httpVersionMajor & httpVersionMinorFeb 18, 2016
@jasnell

Copy link
Copy Markdown
Member

LGTM

@silverwind

Copy link
Copy Markdown
Contributor

Thanks! Landed in c6ae7d0.

silverwind pushed a commit that referenced this pull request Feb 27, 2016
The description of httpVersionMajor & httpVersionMinor should
have same context like httpVersion.
PR-URL: #5296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg pushed a commit that referenced this pull request Feb 28, 2016
The description of httpVersionMajor & httpVersionMinor should
have same context like httpVersion.
PR-URL: #5296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@Fishrock123Fishrock123 mentioned this pull request Mar 1, 2016
5 tasks
@jasnell

Copy link
Copy Markdown
Member

Added the lts watch label...

@JacksonTian
JacksonTian deleted the http_version branch March 3, 2016 02:31
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
The description of httpVersionMajor & httpVersionMinor should
have same context like httpVersion.
PR-URL: #5296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
The description of httpVersionMajor & httpVersionMinor should
have same context like httpVersion.
PR-URL: #5296
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docIssues and PRs related to the documentations.httpIssues or PRs related to the http subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@JacksonTian@jasnell@silverwind@mscdex@MylesBorins