Skip to content

src: convert all endian checks to constexpr - #52974

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:src-cpp20-endian
May 25, 2024
Merged

src: convert all endian checks to constexpr#52974
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:src-cpp20-endian

Conversation

@tniessen

@tniessentniessen commented May 14, 2024

Copy link
Copy Markdown
Member

This is finally possible in C++20 without having to rely on compiler-defined macros, assuming none of our supported platforms are mixed-endian.

Refs: #44411

@tniessen
src: convert all endian checks to constexpr
7387c59
This is finally possible in C++20 without having to rely on
compiler-defined macros, assuming none of our supported platforms are
mixed-endian.
Refs: nodejs#44411
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels May 14, 2024
anonrig
anonrig approved these changes May 14, 2024
View reviewed changes
Comment threadsrc/util.h
A19890

This comment was marked as spam.

Sign in to view

@tniessentniessen added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 14, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 14, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented May 18, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59291/

@tniessentniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label May 25, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 25, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 177b8b9 into nodejs:mainMay 25, 2024
@nodejs-github-bot

nodejs-github-bot commented May 25, 2024

Copy link
Copy Markdown
Collaborator

Landed in 177b8b9

targos pushed a commit that referenced this pull request Jun 1, 2024
@tniessen@targos
src: convert all endian checks to constexpr
6b1731c
This is finally possible in C++20 without having to rely on
compiler-defined macros, assuming none of our supported platforms are
mixed-endian.
Refs: #44411
PR-URL: #52974
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jun 7, 2024
Merged
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@tniessen@soophoo
src: convert all endian checks to constexpr
621e102
This is finally possible in C++20 without having to rely on
compiler-defined macros, assuming none of our supported platforms are
mixed-endian.
Refs: nodejs#44411
PR-URL: nodejs#52974
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@anonriganonriganonrig approved these changes
+1 more reviewer
@A19890A19890A19890 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tniessen@nodejs-github-bot@jasnell@anonrig@A19890@richardlau