Skip to content

test_runner: avoid error when coverage line not found - #53000

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:coverage-dont-throw-if-line-not-found
May 17, 2024
Merged

test_runner: avoid error when coverage line not found#53000
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:coverage-dont-throw-if-line-not-found

Conversation

@MoLow

@MoLowMoLow commented May 15, 2024

Copy link
Copy Markdown
Member

Fixes: #52775

the coverage in this case is pretty useless, but it wont throw after this fix

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels May 15, 2024
@avivkelleravivkeller mentioned this pull request May 15, 2024
Closed
@MoLowMoLow added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 15, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 15, 2024
@MoLow

MoLow commented May 15, 2024

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/59226/

@nodejs-github-bot

nodejs-github-bot commented May 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59228/

@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 16, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 17, 2024
@nodejs-github-bot
nodejs-github-bot merged commit d4442a9 into nodejs:mainMay 17, 2024
@nodejs-github-bot

nodejs-github-bot commented May 17, 2024

Copy link
Copy Markdown
Collaborator

Landed in d4442a9

@MoLow
MoLow deleted the coverage-dont-throw-if-line-not-found branch May 19, 2024 07:14
targos pushed a commit that referenced this pull request May 21, 2024
@MoLow@targos
test_runner: avoid error when coverage line not found
e2211a0
PR-URL: #53000Fixes: #52775
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@RafaelGSSRafaelGSS mentioned this pull request Jun 7, 2024
Merged
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@MoLow@soophoo
test_runner: avoid error when coverage line not found
e8b7781
PR-URL: nodejs#53000Fixes: nodejs#52775
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@MoLow@marco-ippolito
test_runner: avoid error when coverage line not found
ba764db
PR-URL: #53000Fixes: #52775
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@marco-ippolitomarco-ippolito mentioned this pull request Jul 19, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes
@anonriganonriganonrig approved these changes
@cjihrigcjihrigcjihrig approved these changes
@atlowChemiatlowChemiatlowChemi approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.test_runnerIssues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Experimental Test Coverage throws "cannot read properties of undefined (reading: line)"

6 participants

@MoLow@nodejs-github-bot@benjamingr@anonrig@cjihrig@atlowChemi