Skip to content

tools: move webcrypto into no-restricted-properties - #53023

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
zeeqko:eslint-rule-update-no-restricted-properties
May 30, 2024
Merged

tools: move webcrypto into no-restricted-properties#53023
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
zeeqko:eslint-rule-update-no-restricted-properties

Conversation

@zeeqko

@zeeqkozeeqko commented May 16, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Since eslintfixedeslint/eslint#16412 in v8.56.0here and we are on eslintv8.57.0 so that we can take advantage of no-restricted-properties rule for webcrypto.

This is my first pull request to node.js. Please let me know if there is anything to fix.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels May 16, 2024
aduh95
aduh95 reviewed May 16, 2024
View reviewed changes
Comment thread.eslintrc.js Outdated
aduh95
aduh95 reviewed May 16, 2024
View reviewed changes
Comment threadtest/parallel/test-global-webcrypto.js Outdated

@aduh95aduh95May 16, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to disable no-restricted-syntax?

Suggested change
/* eslint-disable no-restricted-properties, no-restricted-syntax */
/* eslint-disable no-restricted-properties */

@jakecastellijakecastelliMay 17, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the no-restricted-syntax error comes from test/.eslintrc.yamlhere I think the no-restricted-properties should also be added into test/.eslintrc.yaml in order to keep the rule consistent.

@zeeqkozeeqkoMay 18, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding no-restricted-properties into test/.eslintrc.yaml will result in more linting errors in other test files. I have added a TODO which I will try to fix in a separate PR.

@zeeqko
zeeqkoforce-pushed the eslint-rule-update-no-restricted-properties branch from ef00f15 to d34b551CompareMay 18, 2024 06:34
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 23, 2024
@aduh95aduh95 mentioned this pull request May 23, 2024
Merged
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2024
@nodejs-github-bot

nodejs-github-bot commented May 23, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59362/

@nodejs-github-bot

nodejs-github-bot commented May 23, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59369/

@nodejs-github-bot

nodejs-github-bot commented May 23, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59375/

@aduh95

aduh95 commented May 23, 2024

Copy link
Copy Markdown
Contributor

Can you rebase please? With the move to flat config, there are some conflicts to solve.

@aduh95aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 23, 2024
@zeeqko
zeeqkoforce-pushed the eslint-rule-update-no-restricted-properties branch from d34b551 to 40fe042CompareMay 26, 2024 10:18
@zeeqko

zeeqko commented May 26, 2024

Copy link
Copy Markdown
ContributorAuthor

Can you rebase please? With the move to flat config, there are some conflicts to solve.

Hi @aduh95, I have rebased my branch. Could you please take a look again and rerun CI for me? Thanks.

I have also removed my TODO as the upgrade of Eslint from v8 to v9 does not cause errors in the test files anymore.

@aduh95

aduh95 commented May 26, 2024

Copy link
Copy Markdown
Contributor

The linter is failing (also it looks like the TODO is still there?)

@zeeqko
tools: move webcrypto into no-restricted-properties
55cd7e8
Since eslint fixedeslint/eslint#16412 and we
are on eslint v8.57.0 so that we can take advantage of
no-restricted-properties rule for webcrypto.
@zeeqko
zeeqkoforce-pushed the eslint-rule-update-no-restricted-properties branch from 40fe042 to 55cd7e8CompareMay 26, 2024 11:03
@zeeqko

zeeqko commented May 26, 2024

Copy link
Copy Markdown
ContributorAuthor

The linter is failing (also it looks like the TODO is still there?)

Oh sorry. I accidentally dropped one of my commit during interactive rebase. Thank you for spotting it! It should be fixed by now.

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 26, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 26, 2024
@nodejs-github-bot

nodejs-github-bot commented May 26, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59431/

@nodejs-github-bot

nodejs-github-bot commented May 27, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59464/

@zeeqko

zeeqko commented May 30, 2024

Copy link
Copy Markdown
ContributorAuthor

Hi @aduh95, I am still seeing 4 failing CI jobs (feels like flaky tests) could you help me take a look, please? Thanks a lot ! 👀

@nodejs-github-bot

nodejs-github-bot commented May 30, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59536/

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 30, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 30, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 74dff83 into nodejs:mainMay 30, 2024
@nodejs-github-bot

nodejs-github-bot commented May 30, 2024

Copy link
Copy Markdown
Collaborator

Landed in 74dff83

targos pushed a commit that referenced this pull request Jun 1, 2024
@zeeqko@targos
tools: move webcrypto into no-restricted-properties
86e80dc
Since eslint fixedeslint/eslint#16412 and we
are on eslint v8.57.0 so that we can take advantage of
no-restricted-properties rule for webcrypto.
PR-URL: #53023
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jun 7, 2024
Merged
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@zeeqko@eliphazbouye
tools: move webcrypto into no-restricted-properties
8f0725b
Since eslint fixedeslint/eslint#16412 and we
are on eslint v8.57.0 so that we can take advantage of
no-restricted-properties rule for webcrypto.
PR-URL: nodejs#53023
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakecastellijakecastellijakecastelli left review comments
@lpincalpincalpinca approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: no-restricted-properties misses destructuring object returned from function call

6 participants

@zeeqko@nodejs-github-bot@aduh95@lpinca@jakecastelli@targos