Uh oh!
There was an error while loading. Please reload this page.
Fix missing property in Cluster Ex. - #5305
Closed
MrOutput wants to merge 1 commit into
Closed
Conversation
jasnell
commented
Feb 19, 2016
Member
LGTM |
MrOutput
commented
Feb 20, 2016
ContributorAuthor
@jasnell Is this the correct format? |
jasnell
commented
Feb 20, 2016
Member
For the most part, yes! although |
`Cluster.setupMaster(options)` Options object was missing an `args` property on the example.
silverwind
commented
Feb 27, 2016
Contributor
Thanks! Landed in 9894c02. |
silverwind pushed a commit
that referenced
this pull request
Feb 27, 2016
`Cluster.setupMaster(options)` Options object was missing an `args` property on the example. PR-URL: #5305 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg pushed a commit
that referenced
this pull request
Feb 28, 2016
`Cluster.setupMaster(options)` Options object was missing an `args` property on the example. PR-URL: #5305 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
commented
Mar 10, 2016
Contributor
Adding LTS watch label. Please remove if not appropriate |
jasnell
commented
Mar 11, 2016
Member
SGTM for LTS |
MylesBorins pushed a commit
that referenced
this pull request
Mar 17, 2016
`Cluster.setupMaster(options)` Options object was missing an `args` property on the example. PR-URL: #5305 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit
that referenced
this pull request
Mar 21, 2016
`Cluster.setupMaster(options)` Options object was missing an `args` property on the example. PR-URL: #5305 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cluster.setupMaster(options)Options object was missing anargsproperty on the example.