Skip to content

src: reduce unnecessary GetCwd calls - #53064

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:remove-unnecessary-cwd
May 22, 2024
Merged

src: reduce unnecessary GetCwd calls#53064
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
anonrig:remove-unnecessary-cwd

Conversation

@anonrig

@anonriganonrig commented May 20, 2024

Copy link
Copy Markdown
Member

Removes unnecessary GetCwd() call.

@anonrig
anonrig requested a review from RafaelGSSMay 20, 2024 01:23
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 20, 2024
RafaelGSS
RafaelGSS reviewed May 20, 2024
View reviewed changes
Comment threadsrc/path.cc
@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 20, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 20, 2024
@nodejs-github-bot

nodejs-github-bot commented May 20, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59315/

@anonriganonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label May 20, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 22, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 695cd8b into nodejs:mainMay 22, 2024
@nodejs-github-bot

nodejs-github-bot commented May 22, 2024

Copy link
Copy Markdown
Collaborator

Landed in 695cd8b

targos pushed a commit that referenced this pull request Jun 1, 2024
@anonrig@targos
src: reduce unnecessary GetCwd calls
4a2c6ff
PR-URL: #53064
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jun 7, 2024
Merged
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@anonrig@eliphazbouye
src: reduce unnecessary GetCwd calls
557f87d
PR-URL: nodejs#53064
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@anonrig@marco-ippolito
src: reduce unnecessary GetCwd calls
32839c6
PR-URL: #53064
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@marco-ippolitomarco-ippolito mentioned this pull request Jul 19, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes
@lpincalpincalpinca approved these changes
@richardlaurichardlaurichardlau approved these changes
@trivikrtrivikrtrivikr approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@anonrig@nodejs-github-bot@benjamingr@lpinca@richardlau@trivikr@RafaelGSS