Skip to content

watch: fix variable dependencyOwners naming - #53101

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jakecastelli:fix-dependencyowner-nameing
May 24, 2024
Merged

watch: fix variable dependencyOwners naming#53101
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jakecastelli:fix-dependencyowner-nameing

Conversation

@jakecastelli

Copy link
Copy Markdown
Member

No description provided.

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label May 22, 2024
@jakecastelli

jakecastelli commented May 22, 2024

Copy link
Copy Markdown
MemberAuthor

On the side: I am trying to debug some of the test runner behaviours - would be greatly appreciated if someone could let me know in nodejs how to use debugger to set a breakpoint in the /lib/internal/test_runner folder. (I am currently using VSCode debug interface).

@MoLowMoLow added the fast-track PRs that do not need to wait for 48 hours to land. label May 22, 2024
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @MoLow. Please 👍 to approve.

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 23, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@MoLowMoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label May 24, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 24, 2024
@nodejs-github-bot
nodejs-github-bot merged commit c7a63b0 into nodejs:mainMay 24, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in c7a63b0

targos pushed a commit that referenced this pull request Jun 1, 2024
PR-URL: #53101
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jun 7, 2024
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
PR-URL: nodejs#53101
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
PR-URL: #53101
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@marco-ippolitomarco-ippolito mentioned this pull request Jul 19, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@jakecastelli@nodejs-github-bot@lpinca@MoLow@Lxxyx@aduh95