Skip to content

test: skip test-setproctitle when ps is not available - #53104

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:skip-test/parallel/test-setproctitle.js
May 25, 2024
Merged

test: skip test-setproctitle when ps is not available#53104
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:skip-test/parallel/test-setproctitle.js

Conversation

@aduh95

Copy link
Copy Markdown
Contributor

ps is a dependency of the test, but not available in all contexts.

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 22, 2024
@VoltrexKeyva

Copy link
Copy Markdown
Contributor

s/avaialble/available in commit message.

@aduh95
aduh95force-pushed the skip-test/parallel/test-setproctitle.js branch from 87cd223 to ea5cbadCompareMay 23, 2024 07:36
@aduh95aduh95 changed the title test: skip test-setproctitle when ps is not avaialbletest: skip test-setproctitle when ps is not availableMay 23, 2024
@lpincalpinca added the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 23, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 23, 2024
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 25, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 25, 2024
@nodejs-github-bot
nodejs-github-bot merged commit e818eee into nodejs:mainMay 25, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in e818eee

@aduh95
aduh95 deleted the skip-test/parallel/test-setproctitle.js branch May 26, 2024 08:19
targos pushed a commit that referenced this pull request Jun 1, 2024
PR-URL: #53104
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jun 7, 2024
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
PR-URL: nodejs#53104
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
PR-URL: #53104
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@marco-ippolitomarco-ippolito mentioned this pull request Jul 19, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@aduh95@VoltrexKeyva@nodejs-github-bot@jasnell@lpinca