build: add --skip-tests to test-ci-js target

[aduh95]

A target that skips building the addons, which for some reason depend on tools/doc/node_modules to be available, which requires the internet.

[richardlau]

building the addons, which for some reason depend on tools/doc/node_modules to be available, which requires the internet.

IIRC this is because it extracts from our API documentation the examples and compiles those as addon tests.
e.g,

node/doc/api/addons.md

Lines 279 to 323 in 4a54a80

	```cpp
	// addon.cc
	#include <node.h>
	#include <assert.h>
	#include <stdlib.h>
	using node::AddEnvironmentCleanupHook;
	using v8::HandleScope;
	using v8::Isolate;
	using v8::Local;
	using v8::Object;
	// Note: In a real-world application, do not rely on static/global data.
	static char cookie[] = "yum yum";
	static int cleanup_cb1_called = 0;
	static int cleanup_cb2_called = 0;
	static void cleanup_cb1(void* arg) {
	Isolate* isolate = static_cast<Isolate*>(arg);
	HandleScope scope(isolate);
	Local<Object> obj = Object::New(isolate);
	assert(!obj.IsEmpty()); // assert VM is still alive
	assert(obj->IsObject());
	cleanup_cb1_called++;
	}
	static void cleanup_cb2(void* arg) {
	assert(arg == static_cast<void*>(cookie));
	cleanup_cb2_called++;
	}
	static void sanity_check(void*) {
	assert(cleanup_cb1_called == 1);
	assert(cleanup_cb2_called == 1);
	}
	// Initialize this addon to be context-aware.
	NODE_MODULE_INIT(/* exports, module, context */) {
	Isolate* isolate = context->GetIsolate();
	AddEnvironmentCleanupHook(isolate, sanity_check, nullptr);
	AddEnvironmentCleanupHook(isolate, cleanup_cb2, cookie);
	AddEnvironmentCleanupHook(isolate, cleanup_cb1, isolate);
	}
	```

ends up in test/addons/01_worker_support.

[aduh95]

I noticed that the test-ci-js target was already doing what I wanted – with the exception that it lacks the node binary as a prerequisite, and it didn't include --skip-tests flag like jstest has.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59443/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59465/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59482/

[richardlau]

I noticed that the test-ci-js target was already doing what I wanted – with the exception that it lacks the node binary as a prerequisite,

That's deliberate -- test-ci-js (and corresponding test-ci-native) is used in node-test-binary-armv7l where the node binary is copied from node-cross-compile via our binary temp git repository (all part of node-test-commit-arm-fanned).

[aduh95]

I noticed that the test-ci-js target was already doing what I wanted – with the exception that it lacks the node binary as a prerequisite,

That's deliberate -- test-ci-js (and corresponding test-ci-native) is used in node-test-binary-armv7l where the node binary is copied from node-cross-compile via our binary temp git repository (all part of node-test-commit-arm-fanned).

Makes sense, that explains the comment just above the rule 👍

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59492/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59508/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/53105
✔ Done loading data for nodejs/node/pull/53105
----------------------------------- PR info ------------------------------------
Title build: add `--skip-tests` to `test-ci-js` target (#53105)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch aduh95:jstest-only -> nodejs:main
Labels build, needs-ci
Commits 1
- build: add `--skip-tests` to `test-ci-js` target
Committers 1
- Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/53105
Reviewed-By: Richard Lau ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/53105
Reviewed-By: Richard Lau --------------------------------------------------------------------------------
ℹ This PR was created on Wed, 22 May 2024 17:05:28 GMT
✔ Approvals: 1
✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/53105#pullrequestreview-2083248397
✘ This PR needs to wait 6 more hours to land (or 0 hours if there is one more approval)
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2024-05-29T08:53:17Z: https://ci.nodejs.org/job/node-test-pull-request/59508/
- Querying data for job/node-test-pull-request/59508/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/9284668581

[nodejs-github-bot]

Landed in 534c122