Skip to content

build: fix --enable-d8 builds - #53106

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardlau:enable_d8
May 24, 2024
Merged

build: fix --enable-d8 builds#53106
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardlau:enable_d8

Conversation

@richardlau

@richardlaurichardlau commented May 22, 2024

Copy link
Copy Markdown
Member

Add v8_abseil as a dependency for d8 and use scraping to pick up the list of source files (including the previously missing src/d8/d8-test.cc).

Fixes these errors with configure --enable-d8:

  • Missing abseil:
In file included from ../deps/v8/src/objects/source-text-module.h:11, from ../deps/v8/src/api/api.h:27, from ../deps/v8/src/api/api-inl.h:9, from ../deps/v8/src/d8/async-hooks-wrapper.cc:11:../deps/v8/src/zone/zone-containers.h:20:10: fatal error: absl/container/flat_hash_map.h: No such file or directory 20 | #include "absl/container/flat_hash_map.h" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~compilation terminated.In file included from ../deps/v8/src/objects/source-text-module.h:11, from ../deps/v8/src/api/api.h:27, from ../deps/v8/src/handles/persistent-handles.h:11, from ../deps/v8/src/heap/local-heap.h:19, from ../deps/v8/src/handles/local-handles.h:12, from ../deps/v8/src/execution/local-isolate.h:12, from ../deps/v8/src/heap/parked-scope.h:11, from ../deps/v8/src/d8/d8.h:25, from ../deps/v8/src/d8/d8-js.cc:5:
  • Missing src/d8/d8-test.cc:
/usr/bin/ld: /home/rlau/sandbox/github/node/out/Release/obj.target/d8/deps/v8/src/d8/d8.o: in function `v8::Shell::CreateD8Template(v8::Isolate*)':
d8.cc:(.text._ZN2v85Shell16CreateD8TemplateEPNS_7IsolateE+0x771): undefined reference to `v8::Shell::CreateTestFastCApiTemplate(v8::Isolate*)'
/usr/bin/ld: d8.cc:(.text._ZN2v85Shell16CreateD8TemplateEPNS_7IsolateE+0x7ac): undefined reference to `v8::Shell::CreateLeafInterfaceTypeTemplate(v8::Isolate*)'
collect2: error: ld returned 1 exit status
make[1]: *** [tools/v8_gypfiles/d8.target.mk:241: /home/rlau/sandbox/github/node/out/Release/d8] Error 1
rm 1df062be45bc7f08255553ef0a19173666eeeef3.intermediate 5af4453f25c9ba66fc65f2b3f6e297922691ce11.intermediate b5964469a6c8ef0a595bcc6dcadd3ff98ad24c40.intermediate
make: *** [Makefile:137: node] Error 2

@richardlau
build: fix --enable-d8 builds
6ea7ef8
Add `v8_abseil` as a dependency for `d8` and use scraping to pick up
the list of source files (including the previously missing
`src/d8/d8-test.cc`).
@nodejs-github-bot

nodejs-github-bot commented May 22, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels May 22, 2024
@richardlaurichardlau added the request-ci Add this label to start a Jenkins CI on a PR. label May 22, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 22, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented May 22, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/5997/

@nodejs-github-bot

nodejs-github-bot commented May 22, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/5997/

@nodejs-github-bot

nodejs-github-bot commented May 22, 2024

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/5997/

mhdawson
mhdawson approved these changes May 22, 2024
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot

nodejs-github-bot commented May 22, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59359/

@richardlaurichardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 22, 2024
@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 23, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 24, 2024
@nodejs-github-bot
nodejs-github-bot merged commit bc13f23 into nodejs:mainMay 24, 2024
@nodejs-github-bot

nodejs-github-bot commented May 24, 2024

Copy link
Copy Markdown
Collaborator

Landed in bc13f23

@richardlau
richardlau deleted the enable_d8 branch May 24, 2024 17:41
targos pushed a commit that referenced this pull request Jun 1, 2024
@richardlau@targos
build: fix --enable-d8 builds
b7d7e9a
Add `v8_abseil` as a dependency for `d8` and use scraping to pick up
the list of source files (including the previously missing
`src/d8/d8-test.cc`).
PR-URL: #53106
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jun 7, 2024
Merged
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@richardlau@soophoo
build: fix --enable-d8 builds
66d0816
Add `v8_abseil` as a dependency for `d8` and use scraping to pick up
the list of source files (including the previously missing
`src/d8/d8-test.cc`).
PR-URL: nodejs#53106
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@richardlau@marco-ippolito
build: fix --enable-d8 builds
bf3d944
Add `v8_abseil` as a dependency for `d8` and use scraping to pick up
the list of source files (including the previously missing
`src/d8/d8-test.cc`).
PR-URL: #53106
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@marco-ippolitomarco-ippolito mentioned this pull request Jul 19, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targostargostargos approved these changes
@legendecaslegendecaslegendecas approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.toolsIssues and PRs related to the tools directory.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@richardlau@nodejs-github-bot@targos@legendecas@mhdawson@aduh95