Uh oh!
There was an error while loading. Please reload this page.
[v20.x] vm: harden module type checks - #53109
Closed
legendecas wants to merge 1 commit into
Closed
Conversation
anonrig
approved these changes
May 22, 2024
nodejs-github-bot
commented
May 23, 2024
Collaborator
marco-ippolito
approved these changes
May 23, 2024
nodejs-github-bot
commented
Jun 12, 2024
Collaborator
marco-ippolitoforce-pushed
the
backport-52162-to-20
branch
from
June 12, 2024 07:42
ed17172 to
f9c85f3Comparenodejs-github-bot
commented
Jun 17, 2024
Collaborator
marco-ippolitoforce-pushed
the
v20.x-staging
branch
2 times, most recently
from
June 17, 2024 14:26
d702971 to
044bcceComparemarco-ippolito
requested changes
Jun 17, 2024
marco-ippolito
left a comment
Member
There was a problem hiding this comment.
Blocking on #53109 (comment)
Check if the value returned from user linker function is a null-ish value. `validateInternalField` should be preferred when checking `this` argument to guard against null-ish `this`. Co-authored-by: Mike Ralphson <mike.ralphson@gmail.com> PR-URL: nodejs#52162 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
legendecasforce-pushed
the
backport-52162-to-20
branch
from
June 18, 2024 09:10
f9c85f3 to
5081f84Comparenodejs-github-bot
commented
Jun 18, 2024
Collaborator
marco-ippolitoforce-pushed
the
v20.x-staging
branch
from
June 19, 2024 09:12
a924e20 to
473fa73Comparemarco-ippolitoforce-pushed
the
v20.x-staging
branch
from
August 19, 2024 08:33
91dea21 to
44268c2Comparetargos
approved these changes
Sep 21, 2024
nodejs-github-bot
commented
Sep 21, 2024
Collaborator
targos
commented
Sep 21, 2024
Member
@marco-ippolito I believe the comment has been addressed. |
marco-ippolito
approved these changes
Sep 21, 2024
nodejs-github-bot
commented
Sep 25, 2024
Collaborator
nodejs-github-bot
commented
Sep 26, 2024
Collaborator
targos pushed a commit
that referenced
this pull request
Sep 26, 2024
Check if the value returned from user linker function is a null-ish value. `validateInternalField` should be preferred when checking `this` argument to guard against null-ish `this`. Co-authored-by: Mike Ralphson <mike.ralphson@gmail.com> PR-URL: #52162 Backport-PR-URL: #53109 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
targos
commented
Sep 26, 2024
Member
Landed in f88bf05 |
targos pushed a commit
that referenced
this pull request
Oct 2, 2024
Check if the value returned from user linker function is a null-ish value. `validateInternalField` should be preferred when checking `this` argument to guard against null-ish `this`. Co-authored-by: Mike Ralphson <mike.ralphson@gmail.com> PR-URL: #52162 Backport-PR-URL: #53109 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
targos pushed a commit
that referenced
this pull request
Oct 2, 2024
Check if the value returned from user linker function is a null-ish value. `validateInternalField` should be preferred when checking `this` argument to guard against null-ish `this`. Co-authored-by: Mike Ralphson <mike.ralphson@gmail.com> PR-URL: #52162 Backport-PR-URL: #53109 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check if the value returned from user linker function is a null-ish value.
validateInternalFieldshould be preferred when checkingthisargument to guard against null-ishthis.Co-authored-by: Mike Ralphson mike.ralphson@gmail.com
PR-URL: #52162
Reviewed-By: Vinícius Lourenço Claro Cardoso contact@viniciusl.com.br
Reviewed-By: Yagiz Nizipli yagiz.nizipli@sentry.io