Skip to content

[v20.x] Revert "Revert "stream: fix cloned webstreams not being unref'd"" - #53144

Closed
marco-ippolito wants to merge 1 commit into
nodejs:v20.x-stagingfrom
marco-ippolito:feat/fix-revert-revert
Closed

[v20.x] Revert "Revert "stream: fix cloned webstreams not being unref'd""#53144
marco-ippolito wants to merge 1 commit into
nodejs:v20.x-stagingfrom
marco-ippolito:feat/fix-revert-revert

Conversation

@marco-ippolito

@marco-ippolitomarco-ippolito commented May 25, 2024

Copy link
Copy Markdown
Member

This reverts commit 8d20b64.
Fixes: #53143

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. v20.x web streams labels May 25, 2024
@marco-ippolitomarco-ippolito mentioned this pull request May 25, 2024
Closed
@marco-ippolito

marco-ippolito commented May 25, 2024•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Apparently "Revert 'Revert" is not valid commit message 😆

@marco-ippolito
marco-ippolitoforce-pushed the feat/fix-revert-revert branch 2 times, most recently from 715d3b5 to 0600cf1CompareMay 25, 2024 06:12
@marco-ippolitomarco-ippolito changed the title [v20.x backport] Revert "Revert "stream: fix cloned webstreams not being unref'd""[v20.] Revert "Revert "stream: fix cloned webstreams not being unref'd""May 25, 2024
@marco-ippolitomarco-ippolito changed the title [v20.] Revert "Revert "stream: fix cloned webstreams not being unref'd""[v20.x] Revert "Revert "stream: fix cloned webstreams not being unref'd""May 25, 2024
@marco-ippolitomarco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label May 25, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 25, 2024
@nodejs-github-bot

nodejs-github-bot commented May 25, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59394/

@nodejs-github-bot

nodejs-github-bot commented May 25, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59397/

@nodejs-github-bot

nodejs-github-bot commented May 25, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59400/

@nodejs-github-bot

nodejs-github-bot commented May 25, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59401/

@nodejs-github-bot

nodejs-github-bot commented May 26, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59415/

@nodejs-github-bot

nodejs-github-bot commented May 26, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59422/

@nodejs-github-bot

nodejs-github-bot commented May 26, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59428/

@marco-ippolito

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented May 27, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59439/

@marco-ippolito
marco-ippolitoforce-pushed the feat/fix-revert-revert branch from 0600cf1 to beedf90CompareMay 27, 2024 11:54
@marco-ippolitomarco-ippolito mentioned this pull request May 27, 2024
Merged
@marco-ippolitomarco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2024
@nodejs-github-bot

nodejs-github-bot commented May 27, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59448/

@nodejs-github-bot

nodejs-github-bot commented May 27, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59457/

mcollina
mcollina approved these changes May 27, 2024
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

marco-ippolito added a commit that referenced this pull request May 27, 2024
@marco-ippolito
Revert "stream: revert fix cloned webstreams not being unref'd"
cffd2cc
This reverts commit 8d20b64.
PR-URL: #53144Fixes: #53143
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
@marco-ippolito

marco-ippolito commented May 27, 2024

Copy link
Copy Markdown
MemberAuthor

Landed in cffd2cc

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes
@jasnelljasnellAwaiting requested review from jasnell

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.web streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marco-ippolito@nodejs-github-bot@mcollina@RafaelGSS