Uh oh!
There was an error while loading. Please reload this page.
build: fix building embedtest in GN build - #53145
Closed
zcbenz wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
commented
May 25, 2024
Collaborator
targos
approved these changes
May 25, 2024
lpinca
approved these changes
May 25, 2024
nodejs-github-bot
commented
May 25, 2024
Collaborator
nodejs-github-bot
commented
May 27, 2024
Collaborator
nodejs-github-bot
commented
May 27, 2024
Collaborator
nodejs-github-bot
commented
May 28, 2024
Collaborator
nodejs-github-bot
commented
May 28, 2024
Collaborator
nodejs-github-bot
commented
May 28, 2024
Collaborator
nodejs-github-bot
commented
May 28, 2024
Collaborator
nodejs-github-bot
commented
May 28, 2024
Collaborator
zcbenz added a commit
that referenced
this pull request
May 28, 2024
PR-URL: #53145 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
zcbenz
commented
May 28, 2024
ContributorAuthor
Landed in 067ab06 |
targos pushed a commit
that referenced
this pull request
Jun 1, 2024
PR-URL: #53145 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
soophoo pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53145 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53145 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the GN build config of embedtest to match the change in #52646.