Uh oh!
There was an error while loading. Please reload this page.
fs: fix cp dir/non-dir mismatch error messages - #53150
Merged
nodejs-github-bot merged 1 commit intoMay 31, 2024
Merged
Conversation
avivkeller
approved these changes
May 25, 2024
avivkeller
left a comment
Member
There was a problem hiding this comment.
LGTM
Tip
I'm a member of the triage team, and not a core collaborator. While my approving review shows my result, it holds now power.
Uh oh!
There was an error while loading. Please reload this page.
The error messages for `ERR_FS_CP_DIR_TO_NON_DIR` and `ERR_FS_CP_NON_DIR_TO_DIR` were the inverse of the copy direction actually performed. Refs: nodejs#44598 (comment)
fahrradfluchtforce-pushed
the
cp-error-messages-fix
branch
from
May 25, 2024 17:37
d62cf9b to
697e2c2Compareaduh95
commented
May 28, 2024
Contributor
/cc @nodejs/fs |
aduh95
approved these changes
May 28, 2024
nodejs-github-bot
commented
May 28, 2024
Collaborator
lpinca
approved these changes
May 28, 2024
nodejs-github-bot
commented
May 28, 2024
Collaborator
fahrradflucht
commented
May 31, 2024
ContributorAuthor
CI failures are flake. |
LiviaMedeiros
approved these changes
May 31, 2024
nodejs-github-bot
commented
May 31, 2024
Collaborator
F3n67u
approved these changes
May 31, 2024
nodejs-github-bot
commented
May 31, 2024
Collaborator
Landed in 00a86fe |
targos pushed a commit
that referenced
this pull request
Jun 1, 2024
The error messages for `ERR_FS_CP_DIR_TO_NON_DIR` and `ERR_FS_CP_NON_DIR_TO_DIR` were the inverse of the copy direction actually performed. Refs: #44598 (comment) PR-URL: #53150 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Feng Yu <F3n67u@outlook.com>
Merged
eliphazbouye pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
The error messages for `ERR_FS_CP_DIR_TO_NON_DIR` and `ERR_FS_CP_NON_DIR_TO_DIR` were the inverse of the copy direction actually performed. Refs: nodejs#44598 (comment) PR-URL: nodejs#53150 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Feng Yu <F3n67u@outlook.com>
marco-ippolito pushed a commit
that referenced
this pull request
Jul 19, 2024
The error messages for `ERR_FS_CP_DIR_TO_NON_DIR` and `ERR_FS_CP_NON_DIR_TO_DIR` were the inverse of the copy direction actually performed. Refs: #44598 (comment) PR-URL: #53150 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Feng Yu <F3n67u@outlook.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error messages for
ERR_FS_CP_DIR_TO_NON_DIRandERR_FS_CP_NON_DIR_TO_DIRwere the inverse of the copy direction actually performed.Refs: #44598 (comment)