Skip to content

doc: fix esm markdown file - #53170

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
popmoore:main
May 27, 2024
Merged

doc: fix esm markdown file#53170
aduh95 merged 1 commit into
nodejs:mainfrom
popmoore:main

Conversation

@popmoore

Copy link
Copy Markdown
Contributor
  • Fix esm doc format

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels May 26, 2024
@deokjinkim

deokjinkim commented May 27, 2024

Copy link
Copy Markdown
Contributor

@popmoore Thank you for your contribution. Please replace docs with doc in commit title.
Below is guidelines for commit message.
https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines

@popmoorepopmoore changed the title docs: fix esm markdown filedoc: fix esm markdown fileMay 27, 2024
@popmoore

Copy link
Copy Markdown
ContributorAuthor

@popmoore Thank you for your contribution. Please replace docs with doc in commit title. Below is guidelines for commit message. https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines

Hi @deokjinkim I changed the commit title, can you approve the CI workflows

@deokjinkimdeokjinkim added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2024
@aduh95aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label May 27, 2024
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@deokjinkim

This comment was marked as off-topic.

@aduh95

This comment was marked as off-topic.

@aduh95
aduh95 merged commit 72a4470 into nodejs:mainMay 27, 2024
@aduh95

Copy link
Copy Markdown
Contributor

Landed in 72a4470

targos pushed a commit that referenced this pull request Jun 1, 2024
PR-URL: #53170
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jun 7, 2024
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
PR-URL: nodejs#53170
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
PR-URL: #53170
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@marco-ippolitomarco-ippolito mentioned this pull request Jul 19, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.esmIssues and PRs related to the ECMAScript Modules implementation.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@popmoore@nodejs-github-bot@deokjinkim@aduh95@GeoffreyBooth@lpinca