Skip to content

vm,src: add property query interceptors - #53172

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
targos:fix-52720
Jun 4, 2024
Merged

vm,src: add property query interceptors#53172
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
targos:fix-52720

Conversation

@targos

@targostargos commented May 27, 2024

Copy link
Copy Markdown
Member

Fixes: #52720

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels May 27, 2024
@targos

targos commented May 27, 2024

Copy link
Copy Markdown
MemberAuthor

/cc @nodejs/cpp-reviewers

@targostargos mentioned this pull request May 27, 2024
Closed
@targos

targos commented May 28, 2024

Copy link
Copy Markdown
MemberAuthor

@nodejs/vm

@joyeecheungjoyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label May 28, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 28, 2024
@nodejs-github-bot

nodejs-github-bot commented May 28, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59488/

@targostargos added dont-land-on-v18.x commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 28, 2024
@targos

targos commented Jun 1, 2024

Copy link
Copy Markdown
MemberAuthor

Can someone else please review?

@targostargos added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 4, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 4, 2024
@nodejs-github-bot
nodejs-github-bot merged commit d1f18b0 into nodejs:mainJun 4, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 4, 2024

Copy link
Copy Markdown
Collaborator

Landed in d1f18b0

@targos
targos deleted the fix-52720 branch June 4, 2024 06:55
@tsctxtsctx mentioned this pull request Jun 5, 2024
Closed
@targostargos added the dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. label Jun 5, 2024
@targostargos mentioned this pull request Jun 5, 2024
Merged
@legendecaslegendecas mentioned this pull request Jun 20, 2024
Closed
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@targos@soophoo
vm,src: add property query interceptors
b8fbf34
Fixes: nodejs#52720
PR-URL: nodejs#53172
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@aduh95aduh95 mentioned this pull request Oct 14, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheungjoyeecheungjoyeecheung approved these changes

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.needs-ciPRs that need a full CI run.vmIssues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent presence of property in contextified object

3 participants

@targos@nodejs-github-bot@joyeecheung