Skip to content

stream: micro-optimize writable condition - #53189

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
orgads:streams-uoptimize
Jun 4, 2024
Merged

stream: micro-optimize writable condition#53189
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
orgads:streams-uoptimize

Conversation

@orgads

@orgadsorgads commented May 28, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@nodejs-github-bot

nodejs-github-bot commented May 28, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label May 28, 2024
@orgads

orgads commented May 29, 2024

Copy link
Copy Markdown
ContributorAuthor

Can you please run the CI?

@benjamingrbenjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
mcollina
mcollina approved these changes May 29, 2024
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@orgads
orgadsforce-pushed the streams-uoptimize branch from b83c501 to 1755e63CompareMay 29, 2024 11:00
@orgadsorgads changed the title streams: micro-optimize writable conditionstream: micro-optimize writable conditionMay 29, 2024
@orgads

orgads commented May 29, 2024

Copy link
Copy Markdown
ContributorAuthor

The commit message had streams instead of stream. Fixed now, please retrigger CI.

@ronagronag added the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2024
@nodejs-github-bot

nodejs-github-bot commented May 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59512/

@MoLowMoLow added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 29, 2024
@orgads
orgadsforce-pushed the streams-uoptimize branch from 1755e63 to 5975965CompareMay 30, 2024 09:55
@mcollinamcollina added the request-ci Add this label to start a Jenkins CI on a PR. label May 30, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 30, 2024
@nodejs-github-bot

nodejs-github-bot commented May 30, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59538/

@orgads
orgadsforce-pushed the streams-uoptimize branch from 5975965 to a66dd43CompareMay 30, 2024 20:51
@orgads

orgads commented May 30, 2024

Copy link
Copy Markdown
ContributorAuthor

Rebased, please retrigger CI.

@ronagronag added the request-ci Add this label to start a Jenkins CI on a PR. label May 30, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 30, 2024
@nodejs-github-bot

nodejs-github-bot commented May 30, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59553/

@orgads

orgads commented May 31, 2024

Copy link
Copy Markdown
ContributorAuthor

Are these failing tests known to be flaky?

@mcollinamcollina added the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2024
@mcollina

mcollina commented May 31, 2024

Copy link
Copy Markdown
Member

let's see

@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2024
@nodejs-github-bot

nodejs-github-bot commented May 31, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59564/

@nodejs-github-bot

nodejs-github-bot commented May 31, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59586/

@nodejs-github-bot

nodejs-github-bot commented Jun 2, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59621/

@orgads

orgads commented Jun 2, 2024

Copy link
Copy Markdown
ContributorAuthor

Finally!

@mcollinamcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jun 4, 2024
@nodejs-github-botnodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 4, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 4, 2024

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/53189
✔ Done loading data for nodejs/node/pull/53189
----------------------------------- PR info ------------------------------------
Title stream: micro-optimize writable condition (#53189)
Author Orgad Shaneh (@orgads)
Branch orgads:streams-uoptimize -> nodejs:main
Labels author ready
Commits 1
- stream: micro-optimize writable condition
Committers 1
- Orgad Shaneh PR-URL: https://github.com/nodejs/node/pull/53189
Reviewed-By: Robert Nagy Reviewed-By: Benjamin Gruenbaum Reviewed-By: Matteo Collina ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/53189
Reviewed-By: Robert Nagy Reviewed-By: Benjamin Gruenbaum Reviewed-By: Matteo Collina --------------------------------------------------------------------------------
⚠ Commits were pushed since the last approving review:
⚠ - stream: micro-optimize writable condition
ℹ This PR was created on Tue, 28 May 2024 19:30:07 GMT
✔ Approvals: 3
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/53189#pullrequestreview-2083817619
✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/53189#pullrequestreview-2083824949
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/53189#pullrequestreview-2085069824
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2024-06-02T18:30:19Z: https://ci.nodejs.org/job/node-test-pull-request/59621/
- Querying data for job/node-test-pull-request/59621/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/9364333050

mcollina
mcollina approved these changes Jun 4, 2024
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 4, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 4, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 7d14d1f into nodejs:mainJun 4, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 4, 2024

Copy link
Copy Markdown
Collaborator

Landed in 7d14d1f

RafaelGSS pushed a commit that referenced this pull request Jun 7, 2024
@orgads@RafaelGSS
stream: micro-optimize writable condition
7c66b27
PR-URL: #53189
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jun 7, 2024
Merged
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@orgads@soophoo
stream: micro-optimize writable condition
c8c80f6
PR-URL: nodejs#53189
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@orgads@marco-ippolito
stream: micro-optimize writable condition
d02651c
PR-URL: #53189
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@marco-ippolitomarco-ippolito mentioned this pull request Jul 19, 2024
Merged
@orgads
orgads deleted the streams-uoptimize branch April 1, 2026 06:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@ronagronagronag approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@orgads@nodejs-github-bot@mcollina@benjamingr@ronag@MoLow