Skip to content

benchmark: fix napi/ref addon - #53233

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:fix-napi-bench
Jun 2, 2024
Merged

benchmark: fix napi/ref addon#53233
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:fix-napi-bench

Conversation

@targos

Copy link
Copy Markdown
Member

@nodejs-github-botnodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label May 31, 2024
@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59580/

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59585/

@targos

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/59591/

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59593/

@targostargos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 1, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59595/

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@H4adH4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 2, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 2, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 881e196 into nodejs:mainJun 2, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 881e196

targos added a commit that referenced this pull request Jun 3, 2024
Refs: #53212 (comment)
PR-URL: #53233
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jun 7, 2024
@targos
targos deleted the fix-napi-bench branch June 10, 2024 09:42
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
Refs: nodejs#53212 (comment)
PR-URL: nodejs#53233
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 19, 2024
Refs: #53212 (comment)
PR-URL: #53233
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 19, 2024
Refs: #53212 (comment)
PR-URL: #53233
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@marco-ippolitomarco-ippolito mentioned this pull request Jul 19, 2024
trevnorris pushed a commit to nodesource/nsolid that referenced this pull request Aug 22, 2024
Refs: nodejs/node#53212 (comment)
PR-URL: nodejs/node#53233
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
trevnorris pushed a commit to nodesource/nsolid that referenced this pull request Aug 23, 2024
Refs: nodejs/node#53212 (comment)
PR-URL: nodejs/node#53233
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.benchmarkIssues and PRs related to the benchmark subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@targos@nodejs-github-bot@lpinca@anonrig@legendecas@H4ad