Uh oh!
There was an error while loading. Please reload this page.
deps: update ada to 2.8.0 - #53254
Merged
Merged
Conversation
CollaboratorAuthor
Review requested:
|
anonrig
commented
Jun 2, 2024
Member
nit: we have done some performance improvements on Ada. @nodejs/performance can anybody run the benchmark ci on URL? |
anonrig
approved these changes
Jun 2, 2024
This comment was marked as outdated.
This comment was marked as outdated.
marco-ippolito
approved these changes
Jun 2, 2024
nodejs-github-bot
commented
Jun 2, 2024
CollaboratorAuthor
jasnell
approved these changes
Jun 2, 2024
nodejs-github-bot
commented
Jun 4, 2024
CollaboratorAuthor
Landed in 0986817 |
RafaelGSS pushed a commit
that referenced
this pull request
Jun 7, 2024
PR-URL: #53254 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
eliphazbouye pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53254 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53254 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
aduh95 pushed a commit
that referenced
this pull request
Nov 3, 2024
PR-URL: #53254 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of ada to 2.8.0.
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1567/