Skip to content

stream: prevent stream unexpected pause when highWaterMark set to 0 - #53261

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jakecastelli:fix-51930
Jun 8, 2024
Merged

stream: prevent stream unexpected pause when highWaterMark set to 0#53261
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
jakecastelli:fix-51930

Conversation

@jakecastelli

@jakecastellijakecastelli commented Jun 2, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #51930

p.s. I noticed that the bot knows to require review from the correct team but the label stream isn't added 👀

@nodejs-github-bot

nodejs-github-bot commented Jun 2, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-botnodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 2, 2024
@jakecastelli

jakecastelli commented Jun 2, 2024

Copy link
Copy Markdown
MemberAuthor

I tend to agree with @ronag on highWaterMark set to 0 does not make much sense but I guess that will be a sermver-major?

@jakecastelli@ronag
stream: prevent stream unexpected pause when highWaterMark set to 0
914d25e
Co-authored-by: Robert Nagy <ronagy@icloud.com>
@vweevers

vweevers commented Jun 2, 2024

Copy link
Copy Markdown
Contributor

See also whatwg/streams#1158 (I'm not sure what the conclusion is there, long read).

@benjamingrbenjamingr added the stream Issues and PRs related to the stream subsystem. label Jun 2, 2024
mcollina
mcollina approved these changes Jun 4, 2024
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@H4adH4ad added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 7, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 7, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 7, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59691/

@nodejs-github-bot

nodejs-github-bot commented Jun 8, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59694/

@H4adH4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 8, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 8, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 50695e5 into nodejs:mainJun 8, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 8, 2024

Copy link
Copy Markdown
Collaborator

Landed in 50695e5

targos pushed a commit that referenced this pull request Jun 20, 2024
@jakecastelli@ronag@targos
stream: prevent stream unexpected pause when highWaterMark set to 0
7dde375
Co-authored-by: Robert Nagy <ronagy@icloud.com>
PR-URL: #53261Fixes: #51930
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@jakecastelli@ronag@soophoo
stream: prevent stream unexpected pause when highWaterMark set to 0
d7330ee
Co-authored-by: Robert Nagy <ronagy@icloud.com>
PR-URL: nodejs#53261Fixes: nodejs#51930
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targostargos mentioned this pull request Jun 25, 2024
Merged
@bsian03bsian03 mentioned this pull request Jul 8, 2024
Closed
@Karliz24Karliz24 mentioned this pull request Jul 9, 2024
Open
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@jakecastelli@ronag@marco-ippolito
stream: prevent stream unexpected pause when highWaterMark set to 0
9f95d41
Co-authored-by: Robert Nagy <ronagy@icloud.com>
PR-URL: #53261Fixes: #51930
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@marco-ippolitomarco-ippolito mentioned this pull request Jul 19, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@benjamingrbenjamingrbenjamingr approved these changes

Assignees

No one assigned

Labels

needs-ciPRs that need a full CI run.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

piping to a stream with highWaterMark: 0 and objectMode: false is broken since node v20.10.0

6 participants

@jakecastelli@nodejs-github-bot@vweevers@mcollina@benjamingr@H4ad