Uh oh!
There was an error while loading. Please reload this page.
tools,doc: parse types in braces everywhere - #5329
Closed
estliberitas wants to merge 1 commit into
Closed
Conversation
ContributorAuthor
There was a problem hiding this comment.
This will have side effects, only if we will write something like....
Some missing {type} or { code: 'without backquote' }
ContributorAuthor
Contributor
There was a problem hiding this comment.
Sorry @estliberitas , since #5641 fixes the broken links, do we still need to remove them?
jasnell
commented
Feb 20, 2016
Member
+1... ok, LGTM! |
silverwind
commented
Feb 27, 2016
Contributor
This needs a rebase now. |
estliberitas
commented
Feb 27, 2016
ContributorAuthor
@silverwind Done |
jasnell
commented
Apr 2, 2016
Member
Oy.. looks like it needs another rebase. If you can get that I'll look at landing next week |
estliberitas
commented
Apr 2, 2016
ContributorAuthor
@jasnell I'll fix tmrw |
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`, `TypeError`, `URIError` to list of global types. Fix errors.markdown copy accordingly. Fixes#5325.
estliberitas
commented
Apr 4, 2016
ContributorAuthor
@jasnell done |
jasnell
commented
Apr 4, 2016
Member
@nodejs/documentation ... another quick review please? :-) |
eljefedelrodeodeljefe
commented
Apr 4, 2016
Contributor
LGTM |
eljefedelrodeodeljefe
commented
Apr 18, 2016
Contributor
ping @jasnell |
jasnell
commented
Apr 18, 2016
Member
LGTM |
jasnell
commented
Apr 18, 2016
Member
Landed in eafd31a |
Closed
joelostrowski pushed a commit
to joelostrowski/node
that referenced
this pull request
Apr 25, 2016
Also add `EvalError`, `RangeError`, `ReferenceError`, `SyntaxError`, `TypeError`, `URIError` to list of global types. Fix errors.markdown copy accordingly. Fixes: nodejs#5325. PR-URL: nodejs#5329 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add
EvalError,RangeError,ReferenceError,SyntaxError,TypeError,URIErrorto list of global types. Fix errors.markdowncopy accordingly.
Fixes#5325.