Uh oh!
There was an error while loading. Please reload this page.
test: fix test-http-server-keepalive-req-gc - #53292
Closed
targos wants to merge 1 commit into
Closed
Conversation
This changes adds a second explicit gc call in the test. Without this call, the test relies on gc eventually happening based, since the first call doesn't free the object. Relying on gc to eventually happen prevents changing GC heuristics unrelated to this test. The gc call is async; otherwise doing multiple sync GCs doesn't free the object.
targos
commented
Jun 3, 2024
MemberAuthor
Adapted from v8#186 |
nodejs-github-bot
commented
Jun 3, 2024
Collaborator
nodejs-github-bot
commented
Jun 6, 2024
Collaborator
targos
commented
Jun 6, 2024
MemberAuthor
@nodejs/v8-update |
lpinca
approved these changes
Jun 7, 2024
nodejs-github-bot
commented
Jun 10, 2024
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/53292 ✔ Done loading data for nodejs/node/pull/53292 ----------------------------------- PR info ------------------------------------ Title test: fix test-http-server-keepalive-req-gc (#53292) Author Michaël Zasso (@targos) Branch targos:robust-gc -> nodejs:main Labels test, needs-ci, commit-queue-rebase Commits 1 - test: fix test-http-server-keepalive-req-gc Committers 1 - Michaël Zasso PR-URL: https://github.com/nodejs/node/pull/53292 Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53292 Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 03 Jun 2024 08:40:03 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/53292#pullrequestreview-2105182781 ✘ This PR needs to wait 0 more hours to land (or 0 hours if there is one more approval) ⚠ GitHub cannot link the author of 'test: fix test-http-server-keepalive-req-gc' to their GitHub account. ⚠ Please suggest them to take a look at https://github.com/nodejs/node/blob/99b1ada/doc/guides/contributing/pull-requests.md#step-1-fork ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-06-06T05:03:41Z: https://ci.nodejs.org/job/node-test-pull-request/59670/ - Querying data for job/node-test-pull-request/59670/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9444846586 |
nodejs-github-bot pushed a commit
that referenced
this pull request
Jun 10, 2024
This changes adds a second explicit gc call in the test. Without this call, the test relies on gc eventually happening based, since the first call doesn't free the object. Relying on gc to eventually happen prevents changing GC heuristics unrelated to this test. The gc call is async; otherwise doing multiple sync GCs doesn't free the object. PR-URL: #53292 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
nodejs-github-bot
commented
Jun 10, 2024
Collaborator
Landed in db09f62...2dea6a4 |
targos pushed a commit
that referenced
this pull request
Jun 20, 2024
This changes adds a second explicit gc call in the test. Without this call, the test relies on gc eventually happening based, since the first call doesn't free the object. Relying on gc to eventually happen prevents changing GC heuristics unrelated to this test. The gc call is async; otherwise doing multiple sync GCs doesn't free the object. PR-URL: #53292 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
soophoo pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
This changes adds a second explicit gc call in the test. Without this call, the test relies on gc eventually happening based, since the first call doesn't free the object. Relying on gc to eventually happen prevents changing GC heuristics unrelated to this test. The gc call is async; otherwise doing multiple sync GCs doesn't free the object. PR-URL: nodejs#53292 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit
that referenced
this pull request
Jul 19, 2024
This changes adds a second explicit gc call in the test. Without this call, the test relies on gc eventually happening based, since the first call doesn't free the object. Relying on gc to eventually happen prevents changing GC heuristics unrelated to this test. The gc call is async; otherwise doing multiple sync GCs doesn't free the object. PR-URL: #53292 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes adds a second explicit gc call in the test. Without this
call, the test relies on gc eventually happening based, since the
first call doesn't free the object.
Relying on gc to eventually happen prevents changing GC heuristics
unrelated to this test.
The gc call is async; otherwise doing multiple sync GCs doesn't free
the object.