Skip to content

doc: indicate requirement on VS 17.6 or newer - #53301

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:doc/windows
Jun 6, 2024
Merged

doc: indicate requirement on VS 17.6 or newer#53301
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:doc/windows

Conversation

@legendecas

@legendecaslegendecas commented Jun 3, 2024

Copy link
Copy Markdown
Member

VS 17.6 or newer is a requirement for all Windows platforms rather than ARM-only.

At the moment this version requirement is only listed under the section "Optional requirements for compiling for Windows 10 on ARM".

@legendecas
doc: indicate requirement on VS 17.6 or newer
56e1615
VS 17.6 or newer is a requirement for all Windows platforms rather
than ARM-only.
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Jun 3, 2024
StefanStojanovic
StefanStojanovic approved these changes Jun 3, 2024
View reviewed changes

@StefanStojanovicStefanStojanovic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 641 * Visual Studio 17.6.0 or newer in the Optional requirements for compiling for Windows 10 on ARM (ARM64): section can be removed since that is added in the mandatory requirements now.

@legendecas

legendecas commented Jun 3, 2024

Copy link
Copy Markdown
MemberAuthor

Line 641 * Visual Studio 17.6.0 or newer in the Optional requirements for compiling for Windows 10 on ARM (ARM64): section can be removed since that is added in the mandatory requirements now.

You can have either one of VS 17.6 or newer, or the Build Tools when building for x64. So it is still good to explicitly say that VS 17.6 or newer is required for ARM builds.

@legendecaslegendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 6, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 6, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 2b7f3d0 into nodejs:mainJun 6, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 6, 2024

Copy link
Copy Markdown
Collaborator

Landed in 2b7f3d0

@legendecas
legendecas deleted the doc/windows branch June 6, 2024 12:58
RafaelGSS pushed a commit that referenced this pull request Jun 7, 2024
@legendecas@RafaelGSS
doc: indicate requirement on VS 17.6 or newer
7bc5f96
VS 17.6 or newer is a requirement for all Windows platforms rather
than ARM-only.
PR-URL: #53301
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@RafaelGSSRafaelGSS mentioned this pull request Jun 7, 2024
Merged
greyaxie

This comment was marked as spam.

Sign in to view

soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@legendecas@soophoo
doc: indicate requirement on VS 17.6 or newer
1d3b24f
VS 17.6 or newer is a requirement for all Windows platforms rather
than ARM-only.
PR-URL: nodejs#53301
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@anonriganonriganonrig approved these changes
@StefanStojanovicStefanStojanovicStefanStojanovic approved these changes
+2 more reviewers
@greyaxiegreyaxiegreyaxie left review comments
@VoltrexKeyvaVoltrexKeyvaVoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@legendecas@nodejs-github-bot@lpinca@anonrig@StefanStojanovic@VoltrexKeyva@greyaxie@richardlau