Uh oh!
There was an error while loading. Please reload this page.
doc, stream: define more cases for event emissions - #53317
Merged
Conversation
avivkeller
commented
Jun 4, 2024
MemberAuthor
CC @nodejs/streams |
mcollina
requested changes
Jun 4, 2024
mcollina
left a comment
Member
There was a problem hiding this comment.
This is missing the information that read() is supposed to be called in a loop.
avivkeller
commented
Jun 4, 2024
MemberAuthor
Added the following sentence: |
mcollina
commented
Jun 7, 2024
Member
Can you lint your commit? |
lpinca
reviewed
Jun 7, 2024
Uh oh!
There was an error while loading. Please reload this page.
lpinca
approved these changes
Jun 7, 2024
nodejs-github-bot
commented
Jun 8, 2024
Collaborator
Landed in 0b02008 |
targos pushed a commit
that referenced
this pull request
Jun 20, 2024
PR-URL: #53317 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
soophoo pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53317 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53317 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#32709
This PR documents more information about Stream's
.read()function and thereadableevent.