Uh oh!
There was an error while loading. Please reload this page.
build: generate binlog in out directories - #53325
Merged
Merged
Conversation
Directories link `Release\` will be created as a junction to `out\Release` when build completes. When binlog was written to `Release\` before the junction is created, the build will fail for unable to create junction when directory `Release\` already exists.
StefanStojanovic
approved these changes
Jun 4, 2024
nodejs-github-bot
commented
Jun 4, 2024
Collaborator
lpinca
approved these changes
Jun 4, 2024
nodejs-github-bot
commented
Jun 6, 2024
Collaborator
Landed in 1aab854 |
RafaelGSS pushed a commit
that referenced
this pull request
Jun 7, 2024
Directories link `Release\` will be created as a junction to `out\Release` when build completes. When binlog was written to `Release\` before the junction is created, the build will fail for unable to create junction when directory `Release\` already exists. PR-URL: #53325 Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
soophoo pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
Directories link `Release\` will be created as a junction to `out\Release` when build completes. When binlog was written to `Release\` before the junction is created, the build will fail for unable to create junction when directory `Release\` already exists. PR-URL: nodejs#53325 Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
marco-ippolito pushed a commit
that referenced
this pull request
Jul 19, 2024
Directories link `Release\` will be created as a junction to `out\Release` when build completes. When binlog was written to `Release\` before the junction is created, the build will fail for unable to create junction when directory `Release\` already exists. PR-URL: #53325 Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Directories like
Release\will be created as a junction toout\Releasewhen build completes. When binlog was written toRelease\before the junction is created, the build will fail forunable to create junction as directory
Release\already exists.