Skip to content

lib: fix naming convention of Symbol - #53387

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
deokjinkim:240608_fix_naming_convention_of_symbol
Jun 10, 2024
Merged

lib: fix naming convention of Symbol#53387
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
deokjinkim:240608_fix_naming_convention_of_symbol

Conversation

@deokjinkim

@deokjinkimdeokjinkim commented Jun 8, 2024

Copy link
Copy Markdown
Contributor

node.js prefix is used for global symbol(Symbol.for). So remove node.js prefix from Symbol usage.

Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring

node/doc/contributing/using-symbols.md

Lines 67 to 68 in 50695e5

In the Node.js runtime we prefix all our global symbols with `nodejs.`,
e.g. `Symbol.for('nodejs.hello')`.

@deokjinkim
lib: fix naming convention of Symbol
309febd
`node.js` prefix is used for global symbol(`Symbol.for`).
So remove `node.js` prefix from `Symbol` usage.
Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring
@nodejs-github-bot

nodejs-github-bot commented Jun 8, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-botnodejs-github-bot added events Issues and PRs related to the events subsystem / EventEmitter. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Jun 8, 2024
mcollina
mcollina approved these changes Jun 8, 2024
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollinamcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 8, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 8, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
lpinca
lpinca approved these changes Jun 8, 2024
View reviewed changes
Comment threadlib/internal/event_target.js Outdated
@deokjinkim@lpinca
Update lib/internal/event_target.js
0883a7e
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
@deokjinkimdeokjinkim added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 9, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 9, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 9, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59701/

H4ad
H4ad approved these changes Jun 9, 2024
View reviewed changes
@H4adH4ad added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 9, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 10, 2024
@nodejs-github-bot
nodejs-github-bot merged commit e74dbfb into nodejs:mainJun 10, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 10, 2024

Copy link
Copy Markdown
Collaborator

Landed in e74dbfb

targos pushed a commit that referenced this pull request Jun 20, 2024
@deokjinkim@targos
lib: fix naming convention of Symbol
45b59e5
`node.js` prefix is used for global symbol(`Symbol.for`).
So remove `node.js` prefix from `Symbol` usage.
Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring
PR-URL: #53387
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@deokjinkim@soophoo
lib: fix naming convention of Symbol
08d7b5c
`node.js` prefix is used for global symbol(`Symbol.for`).
So remove `node.js` prefix from `Symbol` usage.
Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring
PR-URL: nodejs#53387
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@targostargos mentioned this pull request Jun 25, 2024
Merged
@Karliz24Karliz24 mentioned this pull request Jul 9, 2024
Open
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@deokjinkim@marco-ippolito
lib: fix naming convention of Symbol
06374ef
`node.js` prefix is used for global symbol(`Symbol.for`).
So remove `node.js` prefix from `Symbol` usage.
Refs: https://github.com/nodejs/node/blob/main/doc/contributing/using-symbols.md#symbolforstring
PR-URL: #53387
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@marco-ippolitomarco-ippolito mentioned this pull request Jul 19, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@lpincalpincalpinca approved these changes
@H4adH4adH4ad approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.eventsIssues and PRs related to the events subsystem / EventEmitter.http2Issues or PRs related to the http2 subsystem.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@deokjinkim@nodejs-github-bot@mcollina@lpinca@H4ad@marco-ippolito