src: fix permission inspector crash

[theanarkh]

Fixes: #53385

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[cola119]

cc @eugeneo

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59703/

[eugeneo]

Interesting. I see a crash locally (but I did not debug it): ``` $ node --experimental-permission --inspect-brk --eval "console.log('Hi')" Segmentation fault ``` I wonder if this is the same or a different issue.

…

On Sat, Jun 8, 2024 at 8:50 PM theanarkh ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In test/parallel/test-permission-inspector-brk.js <#53389 (comment)>: > +const common = require('../common'); +const assert = require('assert'); +const { spawnSync } = require('child_process'); +const fixtures = require('../common/fixtures'); +const file = fixtures.path('permission', 'inspector-brk.js'); + +common.skipIfWorker(); +common.skipIfInspectorDisabled(); + +const { status, stderr } = spawnSync( + process.execPath, + [ + '--experimental-permission', + '--allow-fs-read=*', + '--inspect-brk', + file, It seems the process does not crash when using --eval because the crash is caused by this <https://github.com/nodejs/node/blob/main/lib/internal/modules/cjs/loader.js#L1425> code. — Reply to this email directly, view it on GitHub <#53389 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACGJLJPMQ4N4X2XFELQLS3ZGPGHBAVCNFSM6AAAAABJAF5ZIWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMBWGA3DCNJZHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[theanarkh]

I will add permission check in node_contextify.cc to fix this(Node.js will run into EvaluateMachine of node_contextify.cc when setting --eval flag).

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59711/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59712/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/59713/

[nodejs-github-bot]

Landed in 430c026