Skip to content

tools: do not run Corepack code before it's reviewed - #53405

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:safer-corepack-update
Jun 12, 2024
Merged

tools: do not run Corepack code before it's reviewed#53405
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:safer-corepack-update

Conversation

@aduh95

Copy link
Copy Markdown
Contributor

Also enable running make corepack-update when node/npm is not available globally.

Also enable running `make corepack-update` when `node`/`npm` is not
available globally.
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jun 10, 2024
@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 10, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 10, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@aduh95aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 10, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 12, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 937ae10 into nodejs:mainJun 12, 2024
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 937ae10

@aduh95
aduh95 deleted the safer-corepack-update branch June 13, 2024 06:42
targos pushed a commit that referenced this pull request Jun 20, 2024
Also enable running `make corepack-update` when `node`/`npm` is not
available globally.
PR-URL: #53405
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
Also enable running `make corepack-update` when `node`/`npm` is not
available globally.
PR-URL: nodejs#53405
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Jun 25, 2024
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
Also enable running `make corepack-update` when `node`/`npm` is not
available globally.
PR-URL: #53405
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@marco-ippolitomarco-ippolito mentioned this pull request Jul 19, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.needs-ciPRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@aduh95@nodejs-github-bot@jasnell@lpinca