Skip to content

tools: fix c-ares update script - #53414

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:feat/fix-c-ares-script
Jun 13, 2024
Merged

tools: fix c-ares update script#53414
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
marco-ippolito:feat/fix-c-ares-script

Conversation

@marco-ippolito

@marco-ippolitomarco-ippolito commented Jun 11, 2024•
edited
Loading

Copy link
Copy Markdown
Member

@nodejs-github-bot

nodejs-github-bot commented Jun 11, 2024•
edited by marco-ippolito
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 11, 2024
@marco-ippolito
marco-ippolitoforce-pushed the feat/fix-c-ares-script branch 2 times, most recently from 22fc5a7 to 64248a8CompareJune 11, 2024 07:42
@anonrig

This comment was marked as resolved.

Sign in to view
@marco-ippolito
marco-ippolitoforce-pushed the feat/fix-c-ares-script branch from 64248a8 to 7edcb34CompareJune 11, 2024 08:29
@marco-ippolitomarco-ippolito changed the title tools: fixed c-ares update scripttools: fix c-ares update scriptJun 11, 2024
@marco-ippolitomarco-ippolito added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 12, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 13, 2024
@nodejs-github-bot
nodejs-github-bot merged commit c64a00a into nodejs:mainJun 13, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 13, 2024

Copy link
Copy Markdown
Collaborator

Landed in c64a00a

targos pushed a commit that referenced this pull request Jun 20, 2024
@marco-ippolito@targos
tools: fix c-ares update script
fe85e05
PR-URL: #53414Fixes: #53407
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@marco-ippolito@soophoo
tools: fix c-ares update script
a30fef1
PR-URL: nodejs#53414Fixes: nodejs#53407
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targostargos mentioned this pull request Jun 25, 2024
Merged
@Karliz24Karliz24 mentioned this pull request Jul 9, 2024
Open
marco-ippolito added a commit that referenced this pull request Jul 19, 2024
@marco-ippolito
tools: fix c-ares update script
53a7b6e
PR-URL: #53414Fixes: #53407
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@marco-ippolitomarco-ippolito mentioned this pull request Jul 19, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@richardlaurichardlaurichardlau approved these changes
@RafaelGSSRafaelGSSRafaelGSS approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

c-ares update script broken by c-ares 1.30.0

6 participants

@marco-ippolito@nodejs-github-bot@anonrig@lpinca@richardlau@RafaelGSS