Skip to content

src: avoid strcmp in favor of operator== - #53439

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:src-avoid-strcmp
Jun 13, 2024
Merged

src: avoid strcmp in favor of operator==#53439
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:src-avoid-strcmp

Conversation

@tniessen

@tniessentniessen commented Jun 13, 2024

Copy link
Copy Markdown
Member

No description provided.

@tniessentniessen added c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 13, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 13, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto

@github-actions

github-actionsBot commented Jun 13, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

@nodejs-github-botnodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Jun 13, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 13, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 13, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59751/

@nodejs-github-bot

nodejs-github-bot commented Jun 13, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59755/

@nodejs-github-bot

nodejs-github-bot commented Jun 13, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59756/

@anonriganonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 13, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 13, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 2bb39f8 into nodejs:mainJun 13, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 13, 2024

Copy link
Copy Markdown
Collaborator

Landed in 2bb39f8

targos pushed a commit that referenced this pull request Jun 20, 2024
@tniessen@targos
src: avoid strcmp in favor of operator==
7d87877
PR-URL: #53439
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@tniessen@soophoo
src: avoid strcmp in favor of operator==
2f7bb78
PR-URL: nodejs#53439
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@targostargos mentioned this pull request Jun 25, 2024
Merged
@Karliz24Karliz24 mentioned this pull request Jul 9, 2024
Open
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@tniessen@marco-ippolito
src: avoid strcmp in favor of operator==
9730d1e
PR-URL: #53439
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@marco-ippolitomarco-ippolito mentioned this pull request Jul 19, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panvapanvapanva approved these changes
@anonriganonriganonrig approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tniessen@nodejs-github-bot@panva@anonrig