Uh oh!
There was an error while loading. Please reload this page.
src: remove SetEncoding from StringEncoder - #53441
Merged
nodejs-github-bot merged 1 commit intoJun 15, 2024
Merged
Conversation
targos
approved these changes
Jun 13, 2024
This comment was marked as outdated.
This comment was marked as outdated.
nodejs-github-bot
commented
Jun 13, 2024
Collaborator
anonrig
commented
Jun 13, 2024
MemberAuthor
cc @nodejs/cpp-reviewers |
jasnell
approved these changes
Jun 13, 2024
lpinca
approved these changes
Jun 13, 2024
lemire
approved these changes
Jun 13, 2024
lemire
left a comment
Member
There was a problem hiding this comment.
There must be a static analyzer that can pinpoint such dead code. Hmmm... Or is that what you used?
nodejs-github-bot
commented
Jun 15, 2024
Collaborator
Landed in d57894d |
targos pushed a commit
that referenced
this pull request
Jun 20, 2024
PR-URL: #53441 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Lemire <daniel@lemire.me>
soophoo pushed a commit
to soophoo/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53441 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Lemire <daniel@lemire.me>
marco-ippolito pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53441 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Lemire <daniel@lemire.me>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes unused
SetEncodingfrom StringEncoder class