Skip to content

test: mitigate flaky test-http-agent - #5346

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:try-stuff
Closed

test: mitigate flaky test-http-agent#5346
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:try-stuff

Conversation

@Trott

@TrottTrott commented Feb 21, 2016

Copy link
Copy Markdown
Member

Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.

Fixes: #5184

@Trott
test: mitigate flaky test-http-agent
76657c5
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.
Fixes: nodejs#5184
@TrottTrott added http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. arm Issues and PRs related to the ARM architecture. lts-watch-v4.x labels Feb 21, 2016
@Trott

Trott commented Feb 21, 2016

Copy link
Copy Markdown
MemberAuthor

Stress test showing this version of the test is not flaky: https://ci.nodejs.org/job/node-stress-single-test/517/nodes=pi2-raspbian-wheezy/console

Stress test showing the version currently in master is flaky: https://ci.nodejs.org/job/node-stress-single-test/510/nodes=pi2-raspbian-wheezy/console

@Trott

Trott commented Feb 21, 2016

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/1711/

@jasnell

jasnell commented Feb 21, 2016

Copy link
Copy Markdown
Member

LGTM

@Trott

Trott commented Feb 22, 2016

Copy link
Copy Markdown
MemberAuthor

ARM failure on CI is due to a known-flaky that Fishrock123 just fixed. Everything else looks good.

@Trott

Trott commented Feb 22, 2016

Copy link
Copy Markdown
MemberAuthor

This one is flaking a lot (just got another one this morning). This fix is tiny and easy to undo. And it only affects test code.

So I'm going to go ahead and land it now under the "trivial changes" clause. If this is bending that rule a bit too much in anyone's opinion, let me know and I'll undo the change and/or try to be more conservative in the future.

Trott added a commit to Trott/io.js that referenced this pull request Feb 22, 2016
@Trott
test: mitigate flaky test-http-agent
bbf4621
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.
Fixes: nodejs#5184
PR-URL: nodejs#5346
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott

Trott commented Feb 22, 2016

Copy link
Copy Markdown
MemberAuthor

Landed in bbf4621

@TrottTrott closed this Feb 22, 2016
rvagg pushed a commit that referenced this pull request Feb 27, 2016
@Trott@rvagg
test: mitigate flaky test-http-agent
991f82b
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.
Fixes: #5184
PR-URL: #5346
Reviewed-By: James M Snell <jasnell@gmail.com>
@Fishrock123Fishrock123 mentioned this pull request Mar 1, 2016
Merged
5 tasks
MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
@TrottMyles Borins
test: mitigate flaky test-http-agent
8899016
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.
Fixes: #5184
PR-URL: #5346
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@TrottMyles Borins
test: mitigate flaky test-http-agent
c86902d
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.
Fixes: #5184
PR-URL: #5346
Reviewed-By: James M Snell <jasnell@gmail.com>
@mscdexmscdex mentioned this pull request Apr 9, 2016
Closed
@Trott
Trott deleted the try-stuff branch January 13, 2022 22:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

armIssues and PRs related to the ARM architecture.httpIssues or PRs related to the http subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Trott@jasnell@MylesBorins