Skip to content

lib: remove the unused code - #53463

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:remove_unused_code
Jun 17, 2024
Merged

lib: remove the unused code#53463
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
theanarkh:remove_unused_code

Conversation

@theanarkh

@theanarkhtheanarkh commented Jun 15, 2024

Copy link
Copy Markdown
Contributor

process.permission.deny have been removed.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Jun 15, 2024
@VoltrexKeyvaVoltrexKeyva added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 15, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 15, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jun 16, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59806/

@nodejs-github-bot

nodejs-github-bot commented Jun 16, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59808/

@marco-ippolitomarco-ippolito added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 17, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 17, 2024
@nodejs-github-bot
nodejs-github-bot merged commit f2381bc into nodejs:mainJun 17, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 17, 2024

Copy link
Copy Markdown
Collaborator

Landed in f2381bc

targos pushed a commit that referenced this pull request Jun 20, 2024
@theanarkh@targos
lib: remove the unused code
123910f
PR-URL: #53463
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
soophoo pushed a commit to soophoo/node that referenced this pull request Jun 20, 2024
@theanarkh@soophoo
lib: remove the unused code
1a03a03
PR-URL: nodejs#53463
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@targostargos mentioned this pull request Jun 25, 2024
Merged
@Karliz24Karliz24 mentioned this pull request Jul 9, 2024
Open
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@theanarkh@marco-ippolito
lib: remove the unused code
55922d9
PR-URL: #53463
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@marco-ippolitomarco-ippolito mentioned this pull request Jul 19, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes
@lpincalpincalpinca approved these changes
@marco-ippolitomarco-ippolitomarco-ippolito approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.needs-ciPRs that need a full CI run.processIssues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@theanarkh@nodejs-github-bot@benjamingr@lpinca@marco-ippolito@VoltrexKeyva