Skip to content

[v20.x backport] src: move package_json_reader cache to c++ - #53502

Closed
anonrig wants to merge 3 commits into
nodejs:v20.x-stagingfrom
anonrig:backport-50322-to-20
Closed

[v20.x backport] src: move package_json_reader cache to c++#53502
anonrig wants to merge 3 commits into
nodejs:v20.x-stagingfrom
anonrig:backport-50322-to-20

Conversation

@anonrig

@anonriganonrig commented Jun 18, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Backports #50322 to v20

cc @nodejs/releasers @joyeecheung@GeoffreyBooth

@nodejs-github-bot

nodejs-github-bot commented Jun 18, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/gyp
  • @nodejs/loaders
  • @nodejs/security-wg
  • @nodejs/startup
  • @nodejs/tsc
  • @nodejs/url

@nodejs-github-botnodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v20.x labels Jun 18, 2024
@anonriganonrig changed the title Backport 50322 to 20[v20.x backport] src: move package_json_reader cache to c++Jun 18, 2024
@anonrig
anonrigforce-pushed the backport-50322-to-20 branch from 8f0ec43 to ff40d15CompareJune 18, 2024 16:28
@marco-ippolitomarco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2024
@richardlau

richardlau commented Jun 18, 2024

Copy link
Copy Markdown
Member

Backport-PR-URL should refer to this PR (while PR-URL refers to the original PR). You don't need to manually add Backport-PR-URL to the commits as node-core/utils will add if missing (if git node land --backport is used to land).

@marco-ippolitomarco-ippolito mentioned this pull request Jun 18, 2024
Closed
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 18, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59869/

@anonrig

anonrig commented Jun 18, 2024

Copy link
Copy Markdown
MemberAuthor

Backport-PR-URL should refer to this PR (while PR-URL refers to the original PR). You don't need to manually add Backport-PR-URL to the commits as node-core/utils will add if missing (if git node land --backport is used to land).

I used git node backport 50322 --to=20 but unfortunately it didn't add at all. I'll update the PR once the existing tests pass (to avoid re-running again)

@joyeecheung

joyeecheung commented Jun 18, 2024

Copy link
Copy Markdown
Member

I think @richardlau meant that you only need to keep the commit message as-is and additional URLs will be added when they land on v20.x-staging.

@marco-ippolito

marco-ippolito commented Jun 26, 2024

Copy link
Copy Markdown
Member

can you please rebase? there are some undici commits we removed from staging

@anonrig
anonrigforce-pushed the backport-50322-to-20 branch from ff40d15 to b447a68CompareJune 27, 2024 15:20
@anonrig
deps: add simdjson
7f4d716
PR-URL: nodejs#50322
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@anonrig
src: move package resolver to c++
19640ce
Co-authored-by: Daniel Lemire <daniel@lemire.me>
PR-URL: nodejs#50322
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
# Conflicts:
#	lib/internal/modules/package_json_reader.js
#	src/node_file.cc
#	test/parallel/test-module-binding.js
@anonrig
module: merge config with package_json_reader
af801aa
PR-URL: nodejs#50322
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@anonrig
anonrigforce-pushed the backport-50322-to-20 branch from b447a68 to af801aaCompareJune 27, 2024 17:36
@marco-ippolitomarco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 15, 2024
@nodejs-github-bot

nodejs-github-bot commented Jul 15, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60336/

@marco-ippolito

marco-ippolito commented Jul 30, 2024

Copy link
Copy Markdown
Member

@anonrig there is some issue with the backport, does not compile

@targos
targosforce-pushed the v20.x-staging branch 2 times, most recently from 47be236 to 9e1c229CompareOctober 2, 2024 14:06
@anonriganonrig closed this Dec 11, 2024
@joyeecheung

joyeecheung commented Jan 13, 2025

Copy link
Copy Markdown
Member

This is blocking the require(esm) backport. I will try to backport it again.

This was referenced Jan 13, 2025
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marco-ippolitomarco-ippolitoAwaiting requested review from marco-ippolito

Assignees

No one assigned

Labels

lib / srcIssues and PRs related to general changes in the lib or src directory.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anonrig@nodejs-github-bot@richardlau@joyeecheung@marco-ippolito