Skip to content

doc: only apply content-visibility on all.html - #53510

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
panva:doc-content-visibility
Jun 19, 2024
Merged

doc: only apply content-visibility on all.html#53510
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
panva:doc-content-visibility

Conversation

@panva

@panvapanva commented Jun 19, 2024

Copy link
Copy Markdown
Member

Refs: #40099 (comment)

content-visibility is the source of bad anchor scrolling behaviours in select browsers that support this rule. This change makes it only apply to the sections in the all.html docs page.

@nodejs-github-bot

nodejs-github-bot commented Jun 19, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/nodejs-website

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 19, 2024
@panvapanva mentioned this pull request Jun 19, 2024
Closed
aduh95
aduh95 approved these changes Jun 19, 2024
View reviewed changes
Comment threaddoc/api_assets/style.css Outdated
@panva@aduh95
Update doc/api_assets/style.css
fa9ae9c
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@panvapanva added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 19, 2024
@MoLowMoLow added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 19, 2024
@github-actions

github-actionsBot commented Jun 19, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @MoLow. Please 👍 to approve.

@MoLow

MoLow commented Jun 19, 2024

Copy link
Copy Markdown
Member

I suggest we get this out as fast as possible @nodejs/releasers

@ovflowd

ovflowd commented Jun 19, 2024

Copy link
Copy Markdown
Member

Feel free to fast-track this. Also indeed, releases if this could be patched on current live API docs (cc @nodejs/build)

@richardlau

richardlau commented Jun 19, 2024

Copy link
Copy Markdown
Member

Feel free to fast-track this. Also indeed, releases if this could be patched on current live API docs (cc @nodejs/build)

This cannot be patched on the current docs and would need new releases.

@panvapanva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 19, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 19, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 67c19c2 into nodejs:mainJun 19, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 19, 2024

Copy link
Copy Markdown
Collaborator

Landed in 67c19c2

@panva
panva deleted the doc-content-visibility branch June 19, 2024 17:22
targos pushed a commit that referenced this pull request Jun 20, 2024
@panva@targos
doc: only apply content-visibility on all.html
a5852cc
Refs: #40099
PR-URL: #53510
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@panva@eliphazbouye
doc: only apply content-visibility on all.html
414c598
Refs: nodejs#40099
PR-URL: nodejs#53510
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
@targostargos mentioned this pull request Jun 25, 2024
Merged
@valadaptivevaladaptive mentioned this pull request Jun 29, 2024
Closed
@Karliz24Karliz24 mentioned this pull request Jul 9, 2024
Open
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@panva@marco-ippolito
doc: only apply content-visibility on all.html
7c3edd9
Refs: #40099
PR-URL: #53510
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
@marco-ippolitomarco-ippolito mentioned this pull request Jul 19, 2024
Merged
@marco-ippolitomarco-ippolito mentioned this pull request Nov 2, 2024
Closed
@aduh95aduh95 mentioned this pull request Nov 7, 2024
Merged
aduh95 pushed a commit that referenced this pull request Nov 7, 2024
@panva@aduh95
doc: only apply content-visibility on all.html
e4739e9
Refs: #40099
PR-URL: #53510
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoLowMoLowMoLow approved these changes
@ovflowdovflowdovflowd approved these changes
@aduh95aduh95aduh95 approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@panva@nodejs-github-bot@MoLow@ovflowd@richardlau@aduh95