Skip to content

tools: update eslint to 9.5.0 - #53515

Merged
nodejs-github-bot merged 2 commits into
mainfrom
actions/tools-update-eslint
Jun 22, 2024
Merged

tools: update eslint to 9.5.0#53515
nodejs-github-bot merged 2 commits into
mainfrom
actions/tools-update-eslint

Conversation

@nodejs-github-bot

@nodejs-github-botnodejs-github-bot commented Jun 19, 2024

Copy link
Copy Markdown
Collaborator

This is an automated update of eslint to 9.5.0.

@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jun 19, 2024
@targos

targos commented Jun 19, 2024

Copy link
Copy Markdown
Member

Update LGTM but it looks like our config is broken: https://github.com/nodejs/node/actions/runs/9587485514/job/26437627528?pr=53515

ESLint: 9.5.0
TypeError: Cannot serialize key "default" in 0: Function values are not supported.
at languageOptionsToJSON (/home/runner/work/node/node/tools/eslint/node_modules/eslint/lib/config/flat-config-array.js:152:23)
at languageOptionsToJSON (/home/runner/work/node/node/tools/eslint/node_modules/eslint/lib/config/flat-config-array.js:146:35)
at languageOptionsToJSON (/home/runner/work/node/node/tools/eslint/node_modules/eslint/lib/config/flat-config-array.js:146:35)
at languageOptionsToJSON (/home/runner/work/node/node/tools/eslint/node_modules/eslint/lib/config/flat-config-array.js:146:35)
at languageOptionsToJSON (/home/runner/work/node/node/tools/eslint/node_modules/eslint/lib/config/flat-config-array.js:146:35)
at Object.value (/home/runner/work/node/node/tools/eslint/node_modules/eslint/lib/config/flat-config-array.js:410:38)
at stringify (/home/runner/work/node/node/tools/eslint/node_modules/json-stable-stringify-without-jsonify/index.js:25:25)
at module.exports (/home/runner/work/node/node/tools/eslint/node_modules/json-stable-stringify-without-jsonify/index.js:68:7)
at hashOfConfigFor (/home/runner/work/node/node/tools/eslint/node_modules/eslint/lib/cli-engine/lint-result-cache.js:50:75)
at LintResultCache.getCachedLintResults (/home/runner/work/node/node/tools/eslint/node_modules/eslint/lib/cli-engine/lint-result-cache.js:116:30)
make: *** [Makefile:[13](https://github.com/nodejs/node/actions/runs/9587485514/job/26437627528?pr=53515#step:5:14)95: lint-js] Error 2

@targos

targos commented Jun 20, 2024

Copy link
Copy Markdown
Member

The problematic part of the config is

node/eslint.config.mjs

Lines 79 to 86 in b952ee1

parserOptions: {
babelOptions: {
plugins: [
babelPluginSyntaxImportAttributes,
],
},
requireConfigFile: false,
},

@targostargos added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 21, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 21, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 21, 2024

Copy link
Copy Markdown
CollaboratorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/59907/

@targostargos added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jun 22, 2024
@targos

targos commented Jun 22, 2024

Copy link
Copy Markdown
Member

@nodejs/linting

aduh95
aduh95 approved these changes Jun 22, 2024
View reviewed changes

@aduh95aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@aduh95aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 22, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 22, 2024
@nodejs-github-bot
nodejs-github-bot merged commit 45c2e25 into mainJun 22, 2024
@nodejs-github-bot
nodejs-github-bot deleted the actions/tools-update-eslint branch June 22, 2024 12:54
@nodejs-github-bot

nodejs-github-bot commented Jun 22, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Landed in 45c2e25

targos pushed a commit that referenced this pull request Jun 25, 2024
@nodejs-github-bot@targos
tools: update eslint to 9.5.0
ca198f4
PR-URL: #53515
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@targostargos mentioned this pull request Jun 25, 2024
Merged
@Karliz24Karliz24 mentioned this pull request Jul 9, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95aduh95aduh95 approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.commit-queue-squashAdd this label to instruct the Commit Queue to squash all the PR commits into the first one.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nodejs-github-bot@targos@aduh95@trivikr@marco-ippolito