Uh oh!
There was an error while loading. Please reload this page.
build: configure with shared sqlite3 - #53519
Merged
Merged
Conversation
nodejs-github-bot
commented
Jun 20, 2024
Collaborator
Review requested:
|
richardlau
approved these changes
Jun 20, 2024
joyeecheung
approved these changes
Jun 20, 2024
tniessen
left a comment
Member
There was a problem hiding this comment.
Should we define a minimum version that we support? I've repeatedly run into issues with the system SQLite being outdated in the past.
legendecas
commented
Jun 20, 2024
MemberAuthor
I think this is a good idea but this sounds needing a CI coverage on sqlite versions to be well guaranteed. We didn't specify a supported version range for other shared deps though, like cares. |
anonrig
approved these changes
Jun 20, 2024
nodejs-github-bot
commented
Jun 21, 2024
Collaborator
tniessen
approved these changes
Jun 21, 2024
RafaelGSS
approved these changes
Jun 21, 2024
nodejs-github-bot
commented
Jun 22, 2024
Collaborator
Landed in 78ea6ce |
targos pushed a commit
that referenced
this pull request
Jun 25, 2024
PR-URL: #53519 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow linking against system installed sqlite3 library.