Uh oh!
There was an error while loading. Please reload this page.
test: extend env for test-node-output-errors - #53535
Merged
nodejs-github-bot merged 1 commit intoJun 23, 2024
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Extend, rather than replace, `env` for `test-node-output-errors` so that `node` binaries that need `LD_LIBRARY_PATH`, `LIBPATH` or `DYLD_LIBRARY_PATH` can run.
richardlauforce-pushed
the
testnodeoutputerrorsfix
branch
from
June 21, 2024 19:07
9426f0e to
83e297bComparenodejs-github-bot
commented
Jun 21, 2024
Collaborator
lpinca
approved these changes
Jun 21, 2024
MoLow
approved these changes
Jun 22, 2024
nodejs-github-bot
commented
Jun 23, 2024
Collaborator
Landed in cd8e61f |
targos pushed a commit
that referenced
this pull request
Jun 25, 2024
Extend, rather than replace, `env` for `test-node-output-errors` so that `node` binaries that need `LD_LIBRARY_PATH`, `LIBPATH` or `DYLD_LIBRARY_PATH` can run. PR-URL: #53535 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
marco-ippolito pushed a commit
that referenced
this pull request
Jul 19, 2024
Extend, rather than replace, `env` for `test-node-output-errors` so that `node` binaries that need `LD_LIBRARY_PATH`, `LIBPATH` or `DYLD_LIBRARY_PATH` can run. PR-URL: #53535 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Merged
codebytere added a commit
to electron/electron
that referenced
this pull request
Jul 25, 2024
codebytere added a commit
to electron/electron
that referenced
this pull request
Jul 26, 2024
jkleinsc pushed a commit
to electron/electron
that referenced
this pull request
Jul 26, 2024
* chore: bump node in DEPS to v20.16.0 * test: skip unstable shadow realm gc tests nodejs/node#52855 * test: extend env for `test-node-output-errors` nodejs/node#53535 * src: fix typo in env.cc nodejs/node#53418 * src: reset `process.versions` during pre-execution nodejs/node#53444 * chore: fixup patch indices * src,permission: --allow-wasi & prevent WASI exec nodejs/node#53124 * tls: use SSL_get_peer_tmp_key nodejs/node#53366 * deps: update c-ares to 1.29.0 nodejs/node#53155 * src: account for OpenSSL unexpected version * crypto: fix propagation of "memory limit exceeded" nodejs/node#53300 * process: add process.getBuiltinModule(id) nodejs/node#52762 * windows 32bit: config change callback needs to be stdcall c-ares/c-ares@8f265c9 * fix: building with UNICODE c-ares/c-ares#802 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend, rather than replace,
envfortest-node-output-errorsso thatnodebinaries that needLD_LIBRARY_PATH,LIBPATHorDYLD_LIBRARY_PATHcan run.