Skip to content

Revert "build: only generate specified build type files" - #53580

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:build/revert-ninja
Jun 26, 2024
Merged

Revert "build: only generate specified build type files"#53580
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:build/revert-ninja

Conversation

@legendecas

@legendecaslegendecas commented Jun 25, 2024

Copy link
Copy Markdown
Member

This reverts commit 6cb940a.

Refs: #53511 (comment)

I think an alternative should be making the generated config.gypi works in both Release mode and Debug mode.

@legendecas
legendecas requested a review from targosJune 25, 2024 09:04
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jun 25, 2024
@targostargos added the dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. label Jun 25, 2024
@legendecaslegendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 25, 2024
@github-actionsgithub-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 25, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 25, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59962/

@legendecaslegendecas added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 25, 2024
@github-actions

github-actionsBot commented Jun 25, 2024

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @legendecas. Please 👍 to approve.

@legendecas

legendecas commented Jun 25, 2024

Copy link
Copy Markdown
MemberAuthor

Fast-tracking the revert to fix the ninja workflow composing with make.

@nodejs-github-bot

nodejs-github-bot commented Jun 25, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59967/

@nodejs-github-bot

nodejs-github-bot commented Jun 26, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59970/

@legendecaslegendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 26, 2024
@nodejs-github-botnodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 26, 2024
@nodejs-github-bot
nodejs-github-bot merged commit ab5e58b into nodejs:mainJun 26, 2024
@nodejs-github-bot

nodejs-github-bot commented Jun 26, 2024

Copy link
Copy Markdown
Collaborator

Landed in ab5e58b

@legendecas
legendecas deleted the build/revert-ninja branch June 26, 2024 09:51
@aduh95aduh95 mentioned this pull request Oct 14, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.dont-land-on-v22.xPRs that should not land on the v22.x-staging branch and should not be released in v22.x.fast-trackPRs that do not need to wait for 48 hours to land.needs-ciPRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@legendecas@nodejs-github-bot@lpinca@targos@richardlau